Add attributes types in SavedObjects migration

[pgayvallet]

In #63943 we added generic types for SavedObjectMigrationFn input and output doc attributes. As these attributes were previously typed as any, some explicit <any, any> were added in existing plugins migrations as a temporary measure.

Now that SavedObjectMigrationFn allows type checking, the existing migrations should leverage it to ensure that migrated docs are correctly typed.

The initial PR introduced<any, any> changes in the following files:

@elastic/kibana-app

• src/plugins/vis_type_timeseries/server/saved_objects/tsvb_telemetry.ts
• x-pack/plugins/graph/server/saved_objects/migrations.ts
• x-pack/plugins/lens/server/migrations.ts

@elastic/kibana-presentation

• src/plugins/dashboard/server/saved_objects/dashboard_migrations.ts
• src/plugins/dashboard/server/saved_objects/migrate_match_all_query.ts

@elastic/kibana-app-arch

• src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
• src/plugins/data/server/saved_objects/index_pattern_migrations.ts
• src/plugins/data/server/saved_objects/search_migrations.ts

@elastic/kibana-security

• x-pack/plugins/spaces/server/saved_objects/migrations/migrate_6x.ts

[wylieconlon]

@pgayvallet @rudolf I've found some issues with the typings that exist that actually prevent us from making these changes in migrations like Lens. I've created a typescript sandbox link which shows why this is currently not possible.

Here are the issues:

• Each migration function should have slightly different parameters as input, to handle the different versions of the saved object. For example, a migration might create a new property or make a property optional.
• We can't use the Record<string, SavedObjectMigrationFn type because of "can't assign to unknown" issues
• We can't use the SavedObjectMigrationMap type because it is not parametrized
• This implies that the only solution is to type the migration functions as any, or to change something else about how we assign these

[pgayvallet]

@wylieconlon your link to the sandbox is incorrect, it's just pointing to https://www.typescriptlang.org/play/index.htm

[wylieconlon]

Sorry, here is the correct link.

[pgayvallet]

I forgot to change the SavedObjectMigrationMap type to allow any type of migration.

The type should be:

SavedObjectMigrationMap {
  [version: string]: SavedObjectMigrationFn<any, any>;
}

Created #65569

[pgayvallet]

No longer relevant - closing