Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: visualize app area charts axis scaling does not scale top hit agg #64734

Closed
tylersmalley opened this issue Apr 29, 2020 · 7 comments · Fixed by #71168
Closed
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience failed-es-promotion Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort v8.0.0

Comments

@tylersmalley
Copy link
Contributor

This failure is preventing the promotion of the current Elasticsearch nightly snapshot.

master/8.0: https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/597/

For more information on the Elasticsearch snapshot promotion process: https://www.elastic.co/guide/en/kibana/master/development-es-snapshots.html

  1) visualize app

         area charts
           axis scaling
             does not scale top hit agg:

      Error: expected [ [ '2015-09-20 00:00', '6', '' ],
  [ '2015-09-20 01:00', '9', '' ],
  [ '2015-09-20 02:00', '22', '' ],
  [ '2015-09-20 03:00', '31', '' ],
  [ '2015-09-20 04:00', '52', '' ],
  [ '2015-09-20 05:00', '119', '' ],
  [ '2015-09-20 06:00', '181', '' ],
  [ '2015-09-20 07:00', '218', '' ],
  [ '2015-09-20 08:00', '341', '' ],
  [ '2015-09-20 09:00', '440', '' ],
  [ '2015-09-20 10:00', '480', '' ],
  [ '2015-09-20 11:00', '517', '' ],
  [ '2015-09-20 12:00', '522', '' ],
  [ '2015-09-20 13:00', '446', '' ],
  [ '2015-09-20 14:00', '403', '' ],
  [ '2015-09-20 15:00', '321', '' ],
  [ '2015-09-20 16:00', '258', '' ],
  [ '2015-09-20 17:00', '172', '' ],
  [ '2015-09-20 18:00', '95', '' ],
  [ '2015-09-20 19:00', '55', '' ] ] to sort of equal [ [ '2015-09-20 00:00', '6', '9.035KB' ],
  [ '2015-09-20 01:00', '9', '5.854KB' ],
  [ '2015-09-20 02:00', '22', '4.588KB' ],
  [ '2015-09-20 03:00', '31', '8.349KB' ],
  [ '2015-09-20 04:00', '52', '2.637KB' ],
  [ '2015-09-20 05:00', '119', '1.712KB' ],
  [ '2015-09-20 06:00', '181', '9.157KB' ],
  [ '2015-09-20 07:00', '218', '8.192KB' ],
  [ '2015-09-20 08:00', '341', '12.384KB' ],
  [ '2015-09-20 09:00', '440', '4.482KB' ],
  [ '2015-09-20 10:00', '480', '9.449KB' ],
  [ '2015-09-20 11:00', '517', '213B' ],
  [ '2015-09-20 12:00', '522', '638B' ],
  [ '2015-09-20 13:00', '446', '7.421KB' ],
  [ '2015-09-20 14:00', '403', '4.854KB' ],
  [ '2015-09-20 15:00', '321', '4.132KB' ],
  [ '2015-09-20 16:00', '258', '601B' ],
  [ '2015-09-20 17:00', '172', '4.239KB' ],
  [ '2015-09-20 18:00', '95', '6.272KB' ],
  [ '2015-09-20 19:00', '55', '2.053KB' ] ]
      + expected - actual

       [
         [
           "2015-09-20 00:00"
           "6"
      -    ""
      +    "9.035KB"
         ]
         [
           "2015-09-20 01:00"
           "9"
      -    ""
      +    "5.854KB"
         ]
         [
           "2015-09-20 02:00"
           "22"
      -    ""
      +    "4.588KB"
         ]
         [
           "2015-09-20 03:00"
           "31"
      -    ""
      +    "8.349KB"
         ]
         [
           "2015-09-20 04:00"
           "52"
      -    ""
      +    "2.637KB"
         ]
         [
           "2015-09-20 05:00"
           "119"
      -    ""
      +    "1.712KB"
         ]
         [
           "2015-09-20 06:00"
           "181"
      -    ""
      +    "9.157KB"
         ]
         [
           "2015-09-20 07:00"
           "218"
      -    ""
      +    "8.192KB"
         ]
         [
           "2015-09-20 08:00"
           "341"
      -    ""
      +    "12.384KB"
         ]
         [
           "2015-09-20 09:00"
           "440"
      -    ""
      +    "4.482KB"
         ]
         [
           "2015-09-20 10:00"
           "480"
      -    ""
      +    "9.449KB"
         ]
         [
           "2015-09-20 11:00"
           "517"
      -    ""
      +    "213B"
         ]
         [
           "2015-09-20 12:00"
           "522"
      -    ""
      +    "638B"
         ]
         [
           "2015-09-20 13:00"
           "446"
      -    ""
      +    "7.421KB"
         ]
         [
           "2015-09-20 14:00"
           "403"
      -    ""
      +    "4.854KB"
         ]
         [
           "2015-09-20 15:00"
           "321"
      -    ""
      +    "4.132KB"
         ]
         [
           "2015-09-20 16:00"
           "258"
      -    ""
      +    "601B"
         ]
         [
           "2015-09-20 17:00"
           "172"
      -    ""
      +    "4.239KB"
         ]
         [
           "2015-09-20 18:00"
           "95"
      -    ""
      +    "6.272KB"
         ]
         [
           "2015-09-20 19:00"
           "55"
      -    ""
      +    "2.053KB"
         ]
       ]

      at Assertion.assert (packages/kbn-expect/expect.js:100:11)
      at Assertion.eql (packages/kbn-expect/expect.js:244:8)
      at Inspector.expectTableData (test/functional/services/inspector.ts:95:23)
      at process._tickCallback (internal/process/next_tick.js:68:7)

           └- ✖ fail: "visualize app  area charts axis scaling does not scale top hit agg"
@tylersmalley tylersmalley added bug Fixes for quality problems that affect the customer experience blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@tylersmalley
Copy link
Contributor Author

Bump - unless it's resolved, we will end up skipping this test today to unblock teams relying on recent snapshots. My fear with this is there is an underlying ES issue here and the more time that goes by the more difficult it becomes to address (ex: revert).

@spalger
Copy link
Contributor

spalger commented Apr 30, 2020

Looks like this is the change that caused issues: https://github.com/elastic/elasticsearch/blob/6cb17a3a71a8a9b097382b394f672aea1b8e70dc/docs/reference/migration/migrate_8_0/search.asciidoc#removal-of-use_field_mapping-for-docvalues-fields

request:
image

response:
image

Looks like we added this parameter a while ago 4447523

@spalger
Copy link
Contributor

spalger commented Apr 30, 2020

Based on this I doubt this will get fixed today so we might as well skip the test and get a blocker for the @elastic/kibana-app team filed.

@timroes timroes added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@timroes
Copy link
Contributor

timroes commented May 7, 2020

Relabbeling that for the App Arch team, since this is caused by the top hit AggConfig which uses these parameters.

@lukeelmers lukeelmers self-assigned this May 14, 2020
@lukeelmers
Copy link
Member

lukeelmers commented May 27, 2020

This should be resolved as a part of #47727

@lukeelmers lukeelmers added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort triaged labels Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience failed-es-promotion Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants