Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Consolidate request validation to io-ts #63525

Open
rylnd opened this issue Apr 14, 2020 · 1 comment
Open

[SIEM] Consolidate request validation to io-ts #63525

rylnd opened this issue Apr 14, 2020 · 1 comment
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM technical debt Improvement of the software architecture and operational architecture

Comments

@rylnd
Copy link
Contributor

rylnd commented Apr 14, 2020 •
edited by spong
Loading

Once #62125 (and probably https://github.com/elastic/siem-team/issues/615) is merged, we'll have a nicer way of validating request that does not require both a request schema and a TS type.

We'll need to make a pass through our routes and:

  • Convert existing request schema from Joi to io-ts (e.g. createRulesBulkSchema)
  • Delete redundant types, e.g. RuleAlertParamsRest

Migrating version labels to description:
Affected versions include: v7.8.0, v7.9.0, v8.0.0
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@lukeelmers lukeelmers added technical debt Improvement of the software architecture and operational architecture and removed technical_debt labels Apr 15, 2020
@rylnd rylnd added the v7.8.0 label Apr 15, 2020
@rylnd rylnd mentioned this issue Apr 15, 2020
Merged
1 task
@spong spong removed the v7.8.0 label Jun 17, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rylnd @lukeelmers @MindyRS @spong @elasticmachine