Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Logstash plugin #60937

Closed
2 of 7 tasks
joshdover opened this issue Mar 23, 2020 · 4 comments · Fixed by #63417
Closed
2 of 7 tasks

Migrate Logstash plugin #60937

joshdover opened this issue Mar 23, 2020 · 4 comments · Fixed by #63417
Assignees
Labels
Feature:Logstash Pipelines Logstash Pipeline UI related Feature:NP Migration Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Logstash

Comments

@joshdover
Copy link
Contributor

joshdover commented Mar 23, 2020

We need to migrate the Logstash plugin in x-pack/legacy/plugins/logstash to the New Platform.

Subtasks:

  • Migrate client-side - this should be prioritized first to help unblock management's migration
    • Refactor all services in public/services to use NP services
    • Move services to plugin class + shim
    • Move logic out of Angular routes & directives into React app
    • Handle dependency between monitoring and logstash (here and here)
    • Migrate to New Platform
      • this could be done as a single step or with a shimming phase. App seems small enough to do in a single step.
  • Migrate server-side [NP] Migrate logstash server side code to NP #63135

Things we are not doing:

  • Converting everything to TypeScript
    • May make sense to use TS in certain places (eg. plugin class), but we are not converting all the existing code to TS as part of this migration.

Resources:

@joshdover joshdover added Feature:Logstash Pipelines Logstash Pipeline UI related Feature:NP Migration Team:Logstash Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

Should the Migrate client-side part be prioritized for 7.8?

@mshustov
Copy link
Contributor

Should the Migrate client-side part be prioritized for 7.8?

It is.

@joshdover It might make sense to get rid of angular.js code as well. UI is already implemented in React, so Angular is a glue layer to the platform.

@joshdover
Copy link
Contributor Author

@joshdover It might make sense to get rid of angular.js code as well. UI is already implemented in React, so Angular is a glue layer to the platform.

Added a subtask 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logstash Pipelines Logstash Pipeline UI related Feature:NP Migration Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Logstash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants