Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav drawer doesn't respect initial locked state #60806

Closed
cjcenizal opened this issue Mar 20, 2020 · 4 comments · Fixed by #61338
Closed

Nav drawer doesn't respect initial locked state #60806

cjcenizal opened this issue Mar 20, 2020 · 4 comments · Fixed by #61338
Assignees
@cjcenizal
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 20, 2020 •
edited
Loading

To reproduce on master:

  1. Lock the nav drawer
  2. Reload Kibana
  3. The nav drawer will be collapsed but it should be locked open

This is possibly related to changes made in #60191

image
@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Mar 20, 2020
@cjcenizal cjcenizal self-assigned this Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@cchaos cchaos added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@cjcenizal cjcenizal mentioned this issue Mar 20, 2020
Merged
@ryankeairns
Copy link
Contributor

@cjcenizal Core UI has been tagged for this issue, but it seems likely to have been introduced by the PR you refer to. Can you shed any more light or look into this further?

@cjcenizal
Copy link
Contributor Author

Thanks for the ping @ryankeairns! I've assigned myself this issue and am looking into it.

@cjcenizal cjcenizal mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjcenizal cjcenizal

Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set initial nav drawer isLocked state in Header constructor cjcenizal/kibana
4 participants
@ryankeairns @cchaos @cjcenizal @elasticmachine