Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License service: possible memory leak #59525

Closed
sebelga opened this issue Mar 6, 2020 · 3 comments
Closed

License service: possible memory leak #59525

sebelga opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sebelga
Copy link
Contributor

sebelga commented Mar 6, 2020

From my comment: #57295 (comment)
we might have a memory leak on the License service that subscribes to license check but never unsubscribe.

licensing.license$.subscribe(license => {
  const { state, message } = license.check(pluginId, minimumLicenseType);
  const hasRequiredLicense = state === LICENSE_CHECK_STATE.Valid;

  if (hasRequiredLicense) {
    this.licenseStatus = { isValid: true };
  } else {
    this.licenseStatus = {
      isValid: false,
      message: message || defaultErrorMessage,
    };
    if (message) {
      logger.info(message);
    }
  }
});
@sebelga sebelga self-assigned this Mar 6, 2020
@sebelga sebelga added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor

@sebelga Is this issue still valid? If so, could you add details in the description regarding the affected app and the file that contains this code? Could you also add a feature label? Thanks!

@cjcenizal
Copy link
Contributor

I looked in this and found that the lifecycle methods are only called when the Kibana server starts up, so we won't create a leak in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants