Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE11] Kibana doesn't transpile correctly in development mode #58108

Closed
afgomez opened this issue Feb 20, 2020 · 11 comments
Closed

[IE11] Kibana doesn't transpile correctly in development mode #58108

afgomez opened this issue Feb 20, 2020 · 11 comments
Labels
bug Fixes for quality problems that affect the customer experience IE11 Team:Operations Team label for Operations Team

Comments

@afgomez
Copy link
Contributor

afgomez commented Feb 20, 2020

Kibana version:
master

Elasticsearch version:
master

Browser version:
IE11

Browser OS version:
Browserstack

Original install method (e.g. download page, yum, from source, etc.):
Source

Describe the bug:
Internet Explorer 11 refuses to load Kibana due to a transpilation error. The code contains a for..of loop which isn't supported in IE11.

Steps to reproduce:

  1. start kibana with BROWSERLISTS_ENV=production yarn start
  2. Open kibana in IE11

Screenshots (if relevant):
Screenshot 2020-02-20 at 12 02 42
Screenshot 2020-02-20 at 12 02 55

@afgomez afgomez added bug Fixes for quality problems that affect the customer experience IE11 labels Feb 20, 2020
@mshustov mshustov added the Team:Operations Team label for Operations Team label Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@chandlerprall
Copy link
Contributor

I believe this is the @elastic/charts dependency (we saw the same error in EUI) - Kibana is on 17.0.2 and there's an IE11 fix in 17.0.3

@tylersmalley
Copy link
Contributor

@markov00, can you take a look at this?

@tylersmalley
Copy link
Contributor

Or someone from @elastic/elastic-charts

@tylersmalley tylersmalley added the Feature:ElasticCharts Issues related to the elastic-charts library label Feb 20, 2020
@joshdover
Copy link
Contributor

@elastic/charts was updated in #57634 but I'm still seeing this problem on master:

image

@joshdover
Copy link
Contributor

joshdover commented Feb 24, 2020

Appears to be an error while eval'ing the punycode npm module, however I don't see any recent changes to which version we use in our yarn.lock. Must be being imported in a way that it wasn't before?

@tylersmalley
Copy link
Contributor

@joshdover looks like punycode was bumped as part of 439708a but since that was merged into 7.6 I would expect to see that issue there as well which I understand isn't the case.

The underlying issue is that ajv, a dependency of punycode, is using template literals.

@joshdover
Copy link
Contributor

I've tracked this down to actually be query-string@6 that was introduced in #56957. v6 does not support IE, but v5 does.

Reverting this does not appear to be an option, there are many files it touched that have been modified since that creates conflicts. I'm going to attempt to downgrade to v5 and see what I break. If it's a lot I will probably delegate this to @elastic/kibana-app-arch who made the original change.

@joshdover
Copy link
Contributor

joshdover commented Feb 27, 2020

There are quite a few changes here required. Will open separate issue for that piece, but I think there are some other issues as well.

Edit: new issue here: #58684

alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 27, 2020
@markov00 markov00 removed the Feature:ElasticCharts Issues related to the elastic-charts library label Mar 2, 2020
@markov00
Copy link
Member

markov00 commented Mar 2, 2020

Sorry folks for the late reply, seems not related to elastic-charts so I removed that label

@tylersmalley
Copy link
Contributor

Closing as the issue referenced here was resolved. In addition, IE 11 support is being dropped as of 7.9 per https://www.elastic.co/support/matrix#matrix_browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience IE11 Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

7 participants