Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify visualization telemetry #56986

Closed
flash1293 opened this issue Feb 6, 2020 · 5 comments · Fixed by #77145
Closed

Simplify visualization telemetry #56986

flash1293 opened this issue Feb 6, 2020 · 5 comments · Fixed by #77145
Assignees
Labels
Feature:Telemetry Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@flash1293
Copy link
Contributor

flash1293 commented Feb 6, 2020

Currently the telemetry for OSS visualizations is using the task manager to run an aggregation job daily collecting telemetry data. As the telemetry service itself makes sure to only run once a day it's not necessary to use the task manager directly anymore - instead, the whole task collecting the data can run directly in the usage collector.

Without task manager the oss_telemetry does not depend on task manager anymore, it can get moved into the visualizations plugin as a service.

@flash1293 flash1293 added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Telemetry Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

@flash1293 At the time this was implemented, the usage collector was being called from a user's browser if needed, and the goal of the usage collectors was to be as fast as possible- this is why the actual aggregation was done separately, and then the results were saved. Has something about this changed so that the usage collector can do more work? This might be a question for members of @elastic/pulse

@wylieconlon wylieconlon added the technical debt Improvement of the software architecture and operational architecture label Apr 17, 2020
@Bamieh
Copy link
Member

Bamieh commented Apr 20, 2020

If the task takes too long then caching it every 24 hours makes sense. If it does not take too long then it is OK to fetch usage on the spot. The telemetry is sent at least once every 24 hours and when users click on the example flyout. If lens is only doing ES queries i believe there would be no need to cache the requests.

@flash1293
Copy link
Contributor Author

@lukeelmers For telemetry of "Visualize visualizations" it looks like it would make sense to move the telemetry into the visualizations plugin. That would imply the app arch team is going to own it (at least temporarily). Do you think that makes sense? The Kibana app team would still take care of migrating it over.

@lukeelmers
Copy link
Member

For telemetry of "Visualize visualizations" it looks like it would make sense to move the telemetry into the visualizations plugin.

Agreed, this was a bit of an ambiguous item anyway when we started migration, but as it tracks usage for all of visualizations, the visualizations plugin feels like a sensible place for it.

cc @ppisljar in case he feels otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants