Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph: Move all field validation logic into deserialize #55968

Open
flash1293 opened this issue Jan 27, 2020 · 3 comments
Open

Graph: Move all field validation logic into deserialize #55968

flash1293 opened this issue Jan 27, 2020 · 3 comments
Labels
Feature:Graph Graph application feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Currently the logic in x-pack/legacy/plugins/graph/public/services/persistence/deserialize.ts filters out some fields from the index pattern object. #54101 introduced additional field validation logic in x-pack/legacy/plugins/graph/public/components/field_manager/field_picker.tsx. This was done to not break workspaces that selected fields disallowed by the new logic in the past.

This behavior should be refactored to do all field filtering logic in one place. To avoid breaking old workspaces, disallowed fields should be mapped to a special field type that allows changing appearance of the nodes, but won't attempt additional explore queries and won't allow to add them again after removal.
@flash1293 flash1293 added chore Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 removed the chore label Jan 27, 2020
@flash1293 flash1293 self-assigned this Jan 27, 2020
@flash1293 flash1293 mentioned this issue Jan 27, 2020
Open
@flash1293 flash1293 removed their assignment Jul 9, 2021
@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Nov 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Graph Graph application feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timroes @flash1293 @elasticmachine @stratoula