Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint rule to forbid importing public code from server code #53021

Closed
joshdover opened this issue Dec 13, 2019 · 1 comment
Closed

Add eslint rule to forbid importing public code from server code #53021

joshdover opened this issue Dec 13, 2019 · 1 comment
Labels
Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Similar to #49053, we could add a lint rule to make sure that client-side code is not imported into server-side code.

While not as critical as #49053, this could prevent attempting to use code that depends on Browser APIs in the Node environment.

One snag here is that when we have both the rules added in #49053 and this, we will not be able to share any code across plugins without also formalizing the "common" directory pattern which specifies code that is safe for both environments.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Dec 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants