Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate custom EuiInMemoryTable to EuiDataGrid #51288

Closed
11 tasks done
walterra opened this issue Nov 21, 2019 · 4 comments
Closed
11 tasks done

[ML] Migrate custom EuiInMemoryTable to EuiDataGrid #51288

walterra opened this issue Nov 21, 2019 · 4 comments
Assignees
Labels

Comments

@walterra
Copy link
Contributor

walterra commented Nov 21, 2019

This is a meta issue to both keep track of issues with the existing custom EuiInMemoryTable and the migration to EuiDataGrid.

Tables to be migrated

Custom EuiInMemoryTable issues

@walterra walterra self-assigned this Nov 21, 2019
@walterra walterra added :ml Feature:Data Frame Analytics ML data frame analytics features Feature:Transforms ML transforms labels Nov 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@Winterflower
Copy link
Contributor

Winterflower commented Mar 26, 2020

Thanks for the discussion on Slack yesterday, @walterra !
As mentioned, in addition to the "Booleans are showing up yes/no", it would be nice to be able to use the query bar above the DF Analytics results table to see which documents are misclassified. For example, in a boolean case, I might want to see where the value in ml.predicted_label does not match the value in label which was the dependent_variable in the DF Analytics job. If I were doing it in a programming language, I would do something like this
ml.predicted_label != label
in Python.
I've been trying to look up examples of how to do this in KQL, but haven't been able to find anything.

@pheyos
Copy link
Member

pheyos commented Apr 9, 2020

Two observations:

  • When I move a column in the selection pop-up, the table reflects that change, but the pop-up still shows it in the old location
  • When I hide the outlier_score column, all the feature_influence columns disappear from the column selection pop-up and they don't come back when I re-select the outlier_score column

od_results_columns_move_and_disable

@walterra
Copy link
Contributor Author

All custom EuiInMemoryTable usages have been migrated to EuiDataGrid. To track further improvements, I created a follow-up meta issue: #64418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants