Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do version check when updating alerts / actions in the client and from the UI #50260

Closed
mikecote opened this issue Nov 12, 2019 · 4 comments
Closed

Do version check when updating alerts / actions in the client and from the UI #50260

mikecote opened this issue Nov 12, 2019 · 4 comments
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

To make 409 errors return if ever task updated elsewhere
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@mikecote mikecote changed the title Do version check when updating alerts / actions in the client Do version check when updating alerts / actions in the client and from the UI Nov 27, 2019
@mikecote
Copy link
Contributor Author

It's currently possible a user stays in the edit UI for a while and in the meantime the alert or action gets updated. Since we don't do version checks, the first changes would get overwritten by the 2nd update.

@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@mikecote mikecote mentioned this issue Sep 9, 2020
Open
@ymao1
Copy link
Contributor

ymao1 commented Mar 4, 2021

Believe this has been fixed but should verify before closing issue.

@mikecote
Copy link
Contributor Author

mikecote commented Mar 4, 2021

@ymao1 relates to #74381. I think we can close both as "won't do" because the system can update the alert quite frequently which wouldn't provide a good UX.

@ymao1 ymao1 closed this as completed Mar 4, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kobelb @bmcconaghy @mikecote @ymao1 @elasticmachine