Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement KQL query bar using EuiSuggest #46079

Closed
andreadelrio opened this issue Sep 18, 2019 · 5 comments
Closed

Implement KQL query bar using EuiSuggest #46079

andreadelrio opened this issue Sep 18, 2019 · 5 comments
Labels
blocked Feature:Filters Feature:Query Bar Querying and query bar features Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.

Comments

@andreadelrio
Copy link
Contributor

@Bargs @TinaHeiligers As a follow-up to #39140 the Eui components for the KQL bar are now ready to be consumed. You can see EuiSuggest here:
https://elastic.github.io/eui/#/forms/suggest

ezgif com-video-to-gif

EuiSuggest displays the state of the query on the right. Supported states are: unsaved, saved, unchanged, loading. (Related to #43747)

EuiSuggest should be able to replace Kibana's QueryBar, SuggestionsComponent and SuggestionComponent. EuiSuggest uses EuiSuggestItem which provides a flexible way to display suggestions (supporting any color and EuiIcon).

We've received feedback about the search bar not having enough room. One way to solve it is expanding the bar on focus. You can see this pattern in action under "Saved queries and filters" in the docs.

ezgif com-video-to-gif_2
@andreadelrio andreadelrio added Feature:Filters Feature:Query Bar Querying and query bar features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@Bargs
Copy link
Contributor

Bargs commented Sep 18, 2019

Looks great @andreadelrio 🎉

@timroes
Copy link
Contributor

timroes commented Sep 19, 2019 •
edited
Loading

This is currently still blocked by a couple of missing implementation details in the suggestion component in EUI (mainly missing accessibility and keyboard navigation), see elastic/eui#1126 (comment)

@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@lukasolson lukasolson added the Feature:Unified search Unified search related tasks label May 12, 2022
@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label May 12, 2022
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Feature:Filters Feature:Query Bar Querying and query bar features Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@timroes @lukasolson @andreadelrio @Bargs @ppisljar @elasticmachine