Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run auth interceptor for unregistered routes #45523

Closed
mshustov opened this issue Sep 12, 2019 · 2 comments
Closed

Do not run auth interceptor for unregistered routes #45523

mshustov opened this issue Sep 12, 2019 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Sep 12, 2019 •
edited
Loading

Kibana version: master

Steps to reproduce:

  1. Run Kibana server
  2. Perform a request to an unregistered route /base-path/adasdfadasdf

Expected behavior:
The server returns 404 and doesn't run auth hook.

Actual behavior:
The server returns 404 and does run auth hook.

Current behavior may lead to unnecessary cookie invalidation. #44513 (comment)

Reason for this behavior is a logic for trailing-slash-url redirection https://github.com/restrry/kibana/blob/cdee299d0a58de9c5e98ee36a35bcd6e66265887/src/legacy/server/http/index.js#L96-L113 introduced in
mshustov@615f4c9
@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@azasypkin azasypkin mentioned this issue Sep 12, 2019
Merged
2 tasks
@mshustov
Copy link
Contributor Author

related #45528

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshdover @mshustov @elasticmachine