Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE11] several events aren't triggered until mouse moves off item #45333

Closed
LeeDr opened this issue Sep 11, 2019 · 6 comments
Closed

[IE11] several events aren't triggered until mouse moves off item #45333

LeeDr opened this issue Sep 11, 2019 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience IE11 Project:Accessibility regression Team:Visualizations Visualization editors, elastic-charts and infrastructure test-ie

Comments

@LeeDr
Copy link

LeeDr commented Sep 11, 2019

Kibana version: master

Elasticsearch version: master

Server OS version: Windows 10

Browser version: Internet Explorer 11

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): source

Describe the bug: While trying to test the addition of IE Driver for running functional tests on IE11 I've noticed several cases now where the UI doesn't change after a link is clicked until the mouse is moved.

Steps to reproduce: Case 1 in Index Patterns

  1. Use IE11
  2. When you start off in Kibana and don't have any index patterns, go to Management, Index Patterns
  3. If you click Index Patterns link and don't move your mouse, the ? help icon and the flyout don't appear
  4. but as soon as you move your mouse off of the Index Patterns link they appear.
    IP
  5. I had to add a moveMouseTo some other object in my PR after clicking Index Patterns to get the correct behavior

Steps to reproduce: Case 2 in Visualize

  1. A similar case where when you go to Visualize the + doesn't appear on the button until you move the mouse
    vis1

Steps to reproduce: Case 3 in Visualize

  1. With no existing visualizations, when you click the link Create new visualization, nothing happens until you move the mouse
  2. Same behavior if you use keyboard navigation to the button.
    vis2

Expected behavior: Mouse users probably wouldn't notice this problem but keyboard users would. And it's going to be a pain to work-around each of these in test automation.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context: This appears to be a regression in master compared to 7.4.0 but my current 7.4.0 Kibana instance has existing index patterns and visualizations so it's not quite the same case.

@LeeDr LeeDr added bug Fixes for quality problems that affect the customer experience regression Project:Accessibility IE11 test-ie labels Sep 11, 2019
@LeeDr
Copy link
Author

LeeDr commented Sep 11, 2019

Found 2 more similar cases. When you click the Dashboard in the nav bar, the + doesn't appear on the Create new dashboard button until the mouse is moved;

dash1

When you click Create new dashboard and click the Add link, nothing happens until you move the mouse;
dash2

@LeeDr
Copy link
Author

LeeDr commented Sep 12, 2019

One more, the dashboard Add menu also doesn't do anything until the mouse is moved.

@LeeDr LeeDr added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@LeeDr
Copy link
Author

LeeDr commented Oct 1, 2019

Add the inspectorPanel on visualizations to this list. But what I found out from the test runner, is that when the Inspect menu item is clicked, the inspector panel does appear in the DOM, but just isn't visible for some reason. If I navigate in IE11 browser console to the inspectorPanel that makes it actually appear in the UI.
inspector

Here's a bit of the FTR log which shows on the last 2 lines that it found the inspectorPanel and moved on, even though the panel isn't visible.

[16:58:52.253383300] │ debg Inspector.open
[16:58:52.316630700] │ debg TestSubjects.exists(inspectorPanel)
[16:58:52.390334500] │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[16:58:52.459217200] │ debg TestSubjects.click(openInspectorButton)
[16:58:52.532388700] │ debg Find.clickByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[16:58:52.597365500] │ debg Find.findByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[16:58:53.690170200] │ debg TestSubjects.moveMouseTo(headerGlobalNav > logo)
[16:58:53.755833000] │ debg TestSubjects.find(headerGlobalNav > logo)
[16:58:53.809062400] │ debg Find.findByCssSelector('[data-test-subj="headerGlobalNav"] [data-test-subj="logo"]') with timeout=10000
[16:58:55.445600600] │ debg TestSubjects.exists(inspectorPanel)
[16:58:55.530350900] │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[16:58:55.842653000] │ debg TestSubjects.find(inspectorPanel)
[16:58:55.925999100] │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[16:58:55.984297600] │ debg Find.clickByButtonText('Rows per page: 20') with timeout=10000
[16:58:56.056157400] │ debg Find.byButtonText('Rows per page: 20') with timeout=10000

In test/functional/services/inspector.ts open() method, I tried changing the await testSubjects.find('inspectorPanel'); to await testSubjects.exists('inspectorPanel'); because it looks like the exists method defaults to find.existsByDisplayedByCssSelector but it apparently thinks it IS displayed.

@LeeDr
Copy link
Author

LeeDr commented Oct 2, 2019

This morning NONE of these problems is reproducible. But a new problem is happening on the index pattern delete button where the modal doesn't appear until the mouse is moved.

inspector

@chandlerprall looked at this particular issue with me and it seems Kibana is thrashing through the euiModal code repeatedly. That might be the cause of flakiness. I'm going to open a new issue on that (see #47133).
image

@timroes
Copy link
Contributor

timroes commented Jun 5, 2020

Since Kibana won't be supporting IE 11 from 7.9.0 onwards, we decided to not address this issue until then and thus closing it now.

@timroes timroes closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience IE11 Project:Accessibility regression Team:Visualizations Visualization editors, elastic-charts and infrastructure test-ie
Projects
None yet
Development

No branches or pull requests

3 participants