Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Agent configuration should indicate whether it was applied remotely or not #43354

Closed
4 tasks
sorenlouv opened this issue Aug 15, 2019 · 6 comments · Fixed by #46995
Closed
4 tasks

[APM] Agent configuration should indicate whether it was applied remotely or not #43354

sorenlouv opened this issue Aug 15, 2019 · 6 comments · Fixed by #46995

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Aug 15, 2019

Currently a user cannot determine if a configuration was successfully applied on an agent or not. They might also want to know how many of their agents have the latest config, and how many are still on an older (perhaps local) config.

The problem of stable agent ids
The initial discussions stalled because agents doesn't have a concept of persistent ids (that are stable across restarts). This means that given two status reports with the first saying config was not applied and the second saying the config was applied we cannot determine if there is one agent that had a problem, restarted and then successfully applied the config; or if there are two agents where one couldn't apply the config and the other could.

Simplification
If we cut some corners we might not need stable agent ids initially. Instead of the UI displaying exactly which agents have the most recent configuration, we will be able to display whether a configuration was applied or not. This will not tell the user whether their entire fleet was updated, but at least they know that a non-zero amount of agents have been updated.

Implementation
APM Server queries elasticsearch for configurations via Kibana on behalf of agents. Agents already send the id of the currently applied configuration as etag. The etag (configuration id) is currently created in APM Server but going forward it should be created in Kibana. The etag can either be a hash of the configuration contents, or simply a randomly generated uuid. The important thing is that it changes every time the config changes.
Whenever Kibana receives an etag it will find the matching configuration and set the applied field to true to indicate that the config has been applied.

TODO

@sorenlouv sorenlouv added [zube]: Inbox discuss enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.5.0 labels Aug 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Sep 2, 2019

Would Successfully applied: 2 minutes ago be an additional column per configuration (row)? Please let me know how I can help with this.

@sorenlouv
Copy link
Member Author

Talking to @jalvz we ended up with not having a timestamp, and just having a boolean flag on each configuration that indicates whether said configuration was applied or not.
I'll update the description.

@sorenlouv
Copy link
Member Author

Please let me know how I can help with this.

I think from a design perspective all we need is to show the status for each configuration (one for each row in the table). We can use the EUI health component:
https://elastic.github.io/eui/#/display/health

@jalvz
Copy link
Contributor

jalvz commented Oct 11, 2019

is this done?

@sorenlouv sorenlouv removed their assignment Oct 11, 2019
@sorenlouv sorenlouv removed Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result to-be-groomed v7.5.0 labels Oct 11, 2019
@sorenlouv
Copy link
Member Author

Fixed in: #46995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants