Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HttpService functionality from Legacy to New platform #39330

Closed
mshustov opened this issue Jun 20, 2019 · 6 comments
Closed

Move HttpService functionality from Legacy to New platform #39330

mshustov opened this issue Jun 20, 2019 · 6 comments
Assignees
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jun 20, 2019

Having #39047 merged we can start moving some pieces of the HTTP server functionality to the new platform.
The task requires investigation to create a list of functionality that is ready to be moved over:

  • HttpMixin (hapi lifecycle events)
  • LoggingMixin (logging via good)
  • request meta-information system api, kibana-xsrf, etc.
  • etc.
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jun 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover
Copy link
Contributor

Need to investigate to figure what is needed now

@mshustov
Copy link
Contributor Author

mshustov commented Nov 14, 2019

Turned out, the legacy server performed a lot of work besides working as HTTP service. There is a list of the created issues to strip off functionality.

Require migration:

CSP

config validation, default CSP rules
link: https://github.com/elastic/kibana/tree/master/src/legacy/server/csp
issue: #50644

i18n

collects translation files and initializes kbn/i18n.
link: https://github.com/elastic/kibana/tree/master/src/legacy/server/i18n
issue: #50647

Http

https://github.com/elastic/kibana/tree/master/src/legacy/server/http

Logging

link: https://github.com/elastic/kibana/tree/master/src/legacy/server/logging
data collection:

infrastructure

Sample data

Sample data sets for demo purposes when a new user starts working with Kibana and doesn't have any data ingested.
link: https://github.com/elastic/kibana/tree/master/src/legacy/server/sample_data
issue: #50675
not sure about owner

Saved Objects

public interface
issue: #33587

Status

Server status, status page
link: https://github.com/elastic/kibana/tree/master/src/legacy/server/status
issue: #41983

Usage collector

collects observable runtime data
link: https://github.com/elastic/kibana/tree/master/src/legacy/server/usage
issue: #46924

Config

link: https://github.com/elastic/kibana/tree/master/src/legacy/server/config
deprecations
issue: #40255
unused config values check
#50680

Non-platform team features

I can be wrong about ownership

@elastic/kibana-operations plugins:

@elastic/kibana-app / @elastic/kibana-app-arch team plugin:

@mistic
Copy link
Member

mistic commented Dec 3, 2019

I'm not sure about the keystore. @tylersmalley is every item listed above correctly assigned to the operations team?

@tylersmalley
Copy link
Contributor

SASS

This does not need migrated over, as we will be moving back to importing via JS in the new platform (#42185 (comment)).

Warnings

Needs confirmed, but I believe this can go away since we are now running node with --no-warnings (https://github.com/elastic/kibana/blob/master/bin/kibana#L24)

Keystore

issue: #52107

PID file

issue: #52108

Config path & data path

Is there already something for this in the new platform to read from the kibana.yml?

Utils/prompt

As far as I can tell, this is just used in the keystore and can be removed as part of #52107

@mshustov
Copy link
Contributor Author

mshustov commented Dec 4, 2019

Config path & data path

#51478 moved them under new platform src/core/server/path/index.ts.

Is there already something for this in the new platform to read from the kibana.yml?

There is only config service coupled with legacy infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

5 participants