Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Design - Central config management for agents #29864

Closed
formgeist opened this issue Feb 1, 2019 · 6 comments
Closed

[APM] Design - Central config management for agents #29864

formgeist opened this issue Feb 1, 2019 · 6 comments
Assignees
Labels
design Team:APM All issues that need APM UI Team support v7.3.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Feb 1, 2019

Summary

Related implementation issue: #34990

As we introduce the option to configure services (agents) from Kibana UI through the apm-server in order to allow for central configuration, we're introducing a Settings page in the APM UI that will contain the 1. configuration creation and 2. list of active configurations.

Design

➡️Marvel prototype

Kapture 2019-06-19 at 15 41 19

Settings page

The Settings page will consist of a simplified APM header controls. No date picker, search bar or environment selector.

Beta flag

For the release we will show a callout explaining that this is a beta feature along with a link to the documentation with supported agents.

01 Settings

Create configuration flow

The flow is meant to allow for a quick and seamless flow in order to setup a configuration for a single service by either all or specific service environments (present at the time of creation).

No configurations

01 Settings

As an initial empty state, we will show a large empty state prompt that leads the user to create a configuration first.

Create configuration flyout

01a Settings - select service

The flyout contains all the options needed to create a configuration that enables sample rate configuration, which will be first and only variable available at the first release. We will add more options later on as we add support.

The configuration cannot be created without all inputs being filled and validated.

Show toast to confirm successful creation of configuration

02a Settings - list configurations

Manage created configurations

Once configurations are created, the user needs an overview of active configurations for each service (agent) and environments.

List of configurations

02a Settings - list configurations

We will display the configurations in a table with the service name, environment, sample rate and last updated timestamp. There's also an option to edit the configuration which invokes the edit configuration flyout.

Edit (and delete) configuration flyout

02b Settings - edit-delete configuration

Beyond displaying all the configuration parameters in the same flyout as the create configuration flyout, there will be an additional section that allows the user to delete the configuration.

@formgeist formgeist self-assigned this Feb 1, 2019
@formgeist formgeist added Team:APM All issues that need APM UI Team support [zube]: Inbox design labels Feb 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist formgeist removed their assignment Mar 27, 2019
@formgeist formgeist self-assigned this Apr 12, 2019
@alvarolobato alvarolobato changed the title [APM] Design - Central config management for APM Server [APM] Design - Central config management for agents Apr 17, 2019
@sorenlouv
Copy link
Member

Open questions:

  • since we will be storing data in ES do we need a migration strategy for 8.0?
  • What are the access control requirements?

@roncohen
Copy link
Contributor

there's a "settings" tab proposal for Logs UI: #39071
seems like a good opportunity to increase the similarity between solutions cc @hbharding

@formgeist
Copy link
Contributor Author

Thanks for the heads up @roncohen - @hbharding we can discuss a consistent pattern for these two if it makes sense.

@formgeist
Copy link
Contributor Author

Feedback/tasks:

  • Validation states, especially copy if values don't validate.
  • Toasts for errors states
    • No permissions to write to index (security/privileges)

@formgeist
Copy link
Contributor Author

Closing in favor of the on-going implementation / PR #39555. We'll create separate issues for other design related tasks to this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Team:APM All issues that need APM UI Team support v7.3.0
Projects
None yet
Development

No branches or pull requests

5 participants