Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config validation should occur up front #20303

Closed
epixa opened this issue Jun 28, 2018 · 5 comments
Closed

Config validation should occur up front #20303

epixa opened this issue Jun 28, 2018 · 5 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@epixa
Copy link
Contributor

epixa commented Jun 28, 2018

In kbn-core today, config validation only occurs when the config is needed (e.g. when using the http-related configurations in the http service. This can result in unreliable behaviors for validation in different situations.

For example, if you are using the BasePathProxy and an invalid configuration that gets flagged by the new platform config (e.g. server.maxPayloadBytes: -1000), the CLI exits almost immediately with the appropriate error message. However, if you do not use the BasePathProxy with that same configuration, then the server starts up fine and then fatal errors a little bit later, which causes a log entry but the process keeps running.

We should validate config consistently, and the ideal behavior is to exit the process with an error message ASAP.

@epixa epixa added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jun 28, 2018
@epixa
Copy link
Contributor Author

epixa commented Jun 28, 2018

@elastic/kibana-platform

@azasypkin
Copy link
Member

azasypkin commented Jun 29, 2018

I tried various ideas, none was ideal, but I believe it should be fixed "automatically" or will require relatively simple change once #19994 is merged.

@epixa
Copy link
Contributor Author

epixa commented Sep 17, 2018

@azasypkin Did #22190 address this?

@azasypkin
Copy link
Member

@azasypkin Did #22190 address this?

Nope, but we handle this much better now, i.e. which causes a log entry but the process keeps running shouldn't happen anymore irrespective to the fact where config validation failed (in the core or in the legacy Kibana).

@mshustov
Copy link
Contributor

closed in #35453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants