-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config validation should occur up front #20303
Comments
@elastic/kibana-platform |
I tried various ideas, none was ideal, but I believe it should be fixed "automatically" or will require relatively simple change once #19994 is merged. |
@azasypkin Did #22190 address this? |
Nope, but we handle this much better now, i.e. |
closed in #35453 |
In
kbn-core
today, config validation only occurs when the config is needed (e.g. when using the http-related configurations in the http service. This can result in unreliable behaviors for validation in different situations.For example, if you are using the BasePathProxy and an invalid configuration that gets flagged by the new platform config (e.g.
server.maxPayloadBytes: -1000
), the CLI exits almost immediately with the appropriate error message. However, if you do not use the BasePathProxy with that same configuration, then the server starts up fine and then fatal errors a little bit later, which causes a log entry but the process keeps running.We should validate config consistently, and the ideal behavior is to exit the process with an error message ASAP.
The text was updated successfully, but these errors were encountered: