Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM new platform requirements #18846

Closed
7 of 10 tasks
epixa opened this issue May 5, 2018 · 6 comments
Closed
7 of 10 tasks

APM new platform requirements #18846

epixa opened this issue May 5, 2018 · 6 comments
Labels
Feature:New Platform Meta stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@epixa
Copy link
Contributor

epixa commented May 5, 2018

In order to power APM entirely from the new platform, we need to complete the following:

@epixa epixa added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Meta Feature:New Platform labels May 5, 2018
@sorenlouv
Copy link
Member

I don't see anything obvious missing. What about the core plugins like ui/chrome - will they be available or rewritten for the new platform?

@epixa
Copy link
Contributor Author

epixa commented May 8, 2018

@sqren ui/chrome isn't a plugin, but yeah, we'll need to pass in that sort of functionality through the core contract instead of importing it like you do today. If you could list the very specific pieces of functionality that you need from chrome, that would be helpful!

@sorenlouv
Copy link
Member

sorenlouv commented May 8, 2018

Core functionality used by APM:

ui/chrome:
getInjected
addBasePath
getUiSettingsClient

ui/metadata:
metadata

@kbn/ui-framework/components
(we should move away from this anyway)

@epixa
Copy link
Contributor Author

epixa commented May 8, 2018

That's great, thanks. Most of those things should be easy to replace.

@spalger The UI settings client is probably one bigger thing we need to sort out for the new platform. I didn't realize folks could grab that through chrome right now.

@sorenlouv
Copy link
Member

sorenlouv commented May 8, 2018

We use the ui settings for getting the user's date format:

chrome.getUiSettingsClient().get('dateFormat:tz');

@epixa
Copy link
Contributor Author

epixa commented Jan 10, 2019

cc @roncohen @alvarolobato

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Meta stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants