Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Raw Documents drilldown broken #18027

Closed
elasticmachine opened this issue Aug 3, 2017 · 1 comment · Fixed by #44587
Closed

[Graph] Raw Documents drilldown broken #18027

elasticmachine opened this issue Aug 3, 2017 · 1 comment · Fixed by #44587
Labels
bug Fixes for quality problems that affect the customer experience Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@elasticmachine
Copy link
Contributor

Original comment by @spalger:

When you choose the Raw Documents drill down in graph it redirects to discover and [object Object] is selected as the index, which causes a warning to be displayed.

image

@elasticmachine
Copy link
Contributor Author

Original comment by @markharwood:

Another issue I see in master is that the Settings panel no longer detects Kibana urls when they are pasted into the drill-down-url edit box. It is not easy for users to turn a Kibana URL into a template due to rison encoding etc so as a convenience we auto-detect and offer to replace the relevant part of Kibana urls that have the empty "*" query by detecting this string:

,query:(query_string:(analyze_wildcard:!t,query:'*'))

unfortunately the default query string (at least in bar chart visualizations) now looks like this:

,query:(language:lucene,query:'')

The code that would need changing is this line from app.js:

  const defaultKibanaQuery = ',query:(query_string:(analyze_wildcard:!t,query:\'*\'))';

Note that this breakage is likely to happen again and is symptomatic of a bigger issue - there is no visualization-independent means of passing in a query definition via URL so each client app like Graph has to poke around inside the internal rison-encoded state of each viz to wire these connections together.

However, there's an even bigger issue here in that we really shouldn't be messing around asking users to build a system by wiring viz URLs together in this way in the first place. We should have infrastructure to allow selections in one Kibana visualization to be re-used as queries or subject matter (think filters aggs) in other visualizations. Something akin to an operating system's Copy and Paste clipboard functionality to give portability of user selections from one app to another without them having to have knowledge of each other. That's probably for another issue though.

@elasticmachine elasticmachine added Feature:Graph Graph application feature bug Fixes for quality problems that affect the customer experience labels Apr 24, 2018
@timroes timroes added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Aug 8, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@spalger spalger removed their assignment Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants