Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both kibana.alert.url and context.alertDetailsUrl for observability alerts #158391

Open
maryam-saeidi opened this issue May 24, 2023 · 6 comments
Assignees
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0
Milestone

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented May 24, 2023

📝 Summary

In v8.8, AO introduced the alert details page for APM Latency threshold and also added context.alertDetailsUrl to the action variables of that rule type here. (We are not using this variable in the default action message yet)

Now we want to add the same parameters to the other observability rule types (#156534), but since we already have kibana.alert.url, the question is whether to move forward with adding context.alertDetailsUrl to all the observability rule types or use kibana.alert.url instead.

After discussion with @XavierM , it seems providing kibana.alert.url as an action variable is complicated, and we might not be able to deliver it in v8.9. On the other hand, we want to ensure that observability users can navigate to a page filtered for that alert sooner.

@XavierM suggested that we continue using context.alertDetailsUrl until the work related to providing all alert fields in the action context is done and then think about a migration plan to update the existing action messages and replace context.alertDetailsUrl with kibana.alert.url. Also, we might need to consider to change the context mapping to a flattened field so our user does need to know what we define here and it will be more an internal sauce for our application.

@maryam-saeidi maryam-saeidi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels May 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi self-assigned this May 24, 2023
@maryam-saeidi
Copy link
Member Author

@simianhacker @mikecote @kobelb What do you think about the approach suggested in this ticket?

@kobelb
Copy link
Contributor

kobelb commented May 24, 2023

@simianhacker @mikecote @kobelb What do you think about the approach suggested in this ticket?

Seems reasonable to me.

@mikecote
Copy link
Contributor

@simianhacker @mikecote @kobelb What do you think about the approach suggested in this ticket?

I spoke with @maryam-saeidi offline and the approach looks good to me too 👍

@simianhacker
Copy link
Member

@simianhacker @mikecote @kobelb What do you think about the approach suggested in this ticket?

Looks good to me

@maryam-saeidi maryam-saeidi changed the title Setting both kibana.alert.url and context.alertDetailsUrl for observability alerts Set both kibana.alert.url and context.alertDetailsUrl for observability alerts May 26, 2023
@emma-raffenne emma-raffenne added this to the 8.11 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0
Projects
None yet
Development

No branches or pull requests

6 participants