Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Flyout uses full screen #145942

Closed
kpatticha opened this issue Nov 21, 2022 · 2 comments
Closed

[APM] Flyout uses full screen #145942

kpatticha opened this issue Nov 21, 2022 · 2 comments
Labels
apm:test-plan-regression bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@kpatticha
Copy link
Contributor

Issue

Screen.Recording.2022-11-21.at.23.14.20.mov

image

Some of the places we use Flyout component

apm • public/components/app/settings/agent_keys/create_agent_key.tsx:
   99    return (
  100:     <EuiFlyout onClose={onCancel} size="s">
  101        <EuiFlyoutHeader hasBorder>

apm • public/components/app/settings/custom_link/create_edit_custom_link_flyout/index.tsx:
  78      <form onSubmit={onSubmit} id="customLink_form">
  79:       <EuiFlyout ownFocus onClose={onClose} size="m">
  80          <EuiFlyoutHeader hasBorder>

apm • public/components/shared/apm_header_action_menu/labs/labs_flyout.tsx:
  85    return (
  86:     <EuiFlyout onClose={onClose}>
  87        <EuiFlyoutHeader hasBorder>

@kpatticha kpatticha added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support apm:test-plan-regression labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kpatticha
Copy link
Contributor Author

closing it as duplicate of #145814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-regression bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

2 participants