Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Page does not show "Global" banner (set in kbn server args) #140307

Closed
wayneseymour opened this issue Sep 8, 2022 · 3 comments · Fixed by #140688
Closed

Login Page does not show "Global" banner (set in kbn server args) #140307

wayneseymour opened this issue Sep 8, 2022 · 3 comments · Fixed by #140688
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Global Banner Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test_xpack_functional

Comments

@wayneseymour
Copy link
Member

wayneseymour commented Sep 8, 2022

Kibana version:
latest main

Elasticsearch version:
latest main

Server OS version:
Mac OS X

Browser version:
Latest MSFT Edge

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):
from source
Describe the bug:
Login Page does not show global banner

Steps to reproduce:

  1. Set global banner via server args:
    kbnTestServer: {
      ...kibanaFunctionalConfig.get('kbnTestServer'),
      serverArgs: [
        ...kibanaFunctionalConfig.get('kbnTestServer.serverArgs'),
        '--xpack.banners.placement=top',
        '--xpack.banners.textContent="global banner text"',
      ],
    },
  1. Login

Expected behavior:
Seeing the "global" banner
Screenshots (if relevant):
Screenshot 2022-09-08 at 16 52 47

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
Affects: #135783

@wayneseymour wayneseymour added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test_xpack_functional labels Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

pgayvallet commented Sep 12, 2022

Reproduced using kibana.yml configuration.

After some investigation, it was caused by #129555 that stopped loading all plugins on anonymous pages.

Adding "enabledOnAnonymousPages": true, to the banners's plugin manifest addresses the issue:

Screenshot 2022-09-12 at 11 15 56

cc @elastic/kibana-security before I push a PR, could you just confirm that we're fine adding the banners plugin to the list of plugins loaded on anonymous pages (just wants to make sure we're not breaking the purpose of #129555 by doing so)

@azasypkin
Copy link
Member

cc https://github.com/orgs/elastic/teams/kibana-security before I push a PR, could you just confirm that we're fine adding the banners plugin to the list of plugins loaded on anonymous pages (just wants to make sure we're not breaking the purpose of #129555 by doing so)

It looks like there is only one potentially sensitive part in the banners plugin - xpack.banners.textContent config and it's not exposed to the browser. Considering that, I don't see any issues with loading banners in "anonymous" context if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Global Banner Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test_xpack_functional
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants