[Stack Monitoring] Update metrics-* index pattern

[klacabane]

Summary

The initial Stack Monitoring expectations for the metrics-* index patterns generated by the integrations packages will change from metrics-{product}.{metricset}-{namespace} to metrics-{product}.stack_monitoring.{metricset}-{namespace}. We should update the SM server code to fetch from this new pattern.

This could be the only place that needs to be updated https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/server/lib/cluster/get_index_patterns.ts#L93

AC

• Stack Monitoring UI is powered by data ingested in the metrics-{product}.stack_monitoring.{metricset}-{namespace} pattern

[elasticmachine]

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

[klacabane]

Work to bring integrations package to a GA state is approaching and the naming of the dataset is one of the decision that has impact on other main tasks, I'd love to get consensus of the naming before we dive into these. The last discussion pointed at metrics-{product}.stack_monitoring.{metricset}-{namespace} to clarify the usage of these datastreams, but maybe that's not explicit enough ?
@elastic/infra-monitoring-ui @jasonrhodes @neptunian any other suggestions, or objections to use this suffix ?

[matschaffer]

I don't see any strong reason against it, but I can't remember why the stack_monitoring is being added. Mind refreshing me?

You say "will change" in the description, is it due to the package naming?

[klacabane]

The idea is to free the standard names so the PO packages will be able to use them and at the same time bake more context in the index names (more details here). Now whether PO packages will be able to specify the index naming is still tbd but a more precise naming for the stack monitoring ones remains a benefit

[matschaffer]

Thanks for the refresher @klacabane ! SGTM - if naming is hard I could see maybe using version numbers at some point. For example, it's not clear how to differentiate two potential different otel schemas (perhaps an instrumentation point gets removed in code) if they're both metrics-elasticsearch.node-default

But like you said naming there is still TBD, so shouldn't impact this issue.