Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session View] Update User icon to the new one #131101

Closed
opauloh opened this issue Apr 27, 2022 · 7 comments
Closed

[Session View] Update User icon to the new one #131101

opauloh opened this issue Apr 27, 2022 · 7 comments
Assignees
Labels
Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.4.0

Comments

@opauloh
Copy link
Contributor

opauloh commented Apr 27, 2022

Summary

The AWP Design team proposes a new user Icon for the Session View, as stated on the ➡️ Figma file, as the Eui Library already have a User Icon we're going to propose a change instead of adding a new user Icon

Screenshot of the new User Icon:

image

@opauloh opauloh changed the title Old user icon needs a switch to a new one Figma file Old user icon needs a switch to a new one Apr 27, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 27, 2022
@opauloh opauloh added the Team: AWP: Visualization AWP team that does most fullstack work in kibana label Apr 27, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 27, 2022
@opauloh opauloh self-assigned this Apr 27, 2022
@opauloh opauloh added the v8.3.0 label Apr 27, 2022
@opauloh opauloh changed the title Old user icon needs a switch to a new one [Session View] Update User icon to the new one Apr 27, 2022
@opauloh
Copy link
Contributor Author

opauloh commented Apr 27, 2022

@codearos can you help me with a summary for me to add on the EuiIcon PR, of why we're proposing a change to the user Icon?

@codearos
Copy link

codearos commented May 4, 2022

@opauloh Sure.

  • We're proposing a new style for user-icon to make it more consistent in the library. In most of the cases we're using outlines icons.
  • It's also visually lighter, so that it can be used without drawing too much attention.

@opauloh
Copy link
Contributor Author

opauloh commented May 5, 2022

Thanks, @codearos

Pushed a PR into Eui proposing the Icon change: elastic/eui#5877

@opauloh opauloh closed this as completed May 16, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

Hi @opauloh

we have validated this issue on 8.3.0 BC2 but mentioned icon of user is not there. we will going to re-test the issue on BC3 in case pr commit got missed to there in BC2 .

Build Details:

Version: 8.3.0 BC2
Commit:25476b531ba9f32292bde85508d342aa5e1c29eb
Build:53231

Screen-Cast:

Expected: ✔️

image

Actual:

image

c.c @MadameSheema

@opauloh
Copy link
Contributor Author

opauloh commented Jun 7, 2022

Hi @karanbirsingh-qasource,

Just checked and it looks like the EUI upgrade PR in Kibana which contains the EuiIcon changes won't make the v8.3.

Since it's not critical, I'm going to target this issue for v8.4 then, thanks!

cc @qcorporation @codearos

@opauloh opauloh added v8.4.0 and removed v8.3.0 labels Jun 7, 2022
@opauloh opauloh reopened this Jun 7, 2022
@qcorporation
Copy link

thanks for digging into this @opauloh

@ghost
Copy link

ghost commented Jun 8, 2022

Hi @karanbirsingh-qasource,

Just checked and it looks like the EUI upgrade PR in Kibana which contains the EuiIcon changes won't make the v8.3.

Since it's not critical, I'm going to target this issue for v8.4 then, thanks!

cc @qcorporation @codearos

thanks @opauloh for looking into the comment and sharing the update 👍

@opauloh opauloh closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.4.0
Projects
None yet
Development

No branches or pull requests

3 participants