Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default_field instead of all_fields in highlight query #13096

Closed
Bargs opened this issue Jul 25, 2017 · 2 comments
Closed

Use default_field instead of all_fields in highlight query #13096

Bargs opened this issue Jul 25, 2017 · 2 comments
Assignees
@lukasolson
Labels
blocker chore Feature:Highlight Highlighting of content via query PR sent v7.0.0

Comments

@Bargs
Copy link
Contributor

Bargs commented Jul 25, 2017

We use the all_fields param in a highlight query when the doc_table:highlight:all_fields advanced setting is true. all_fields is deprecated now, we need to switch to using default_field: *
@epixa
Copy link
Contributor

epixa commented Jul 25, 2017

@Bargs I'm going to mark this a blocker for 7.0 since I presume the use_all_fields feature will be removed in 7.0

@epixa
Copy link
Contributor

epixa commented Jul 28, 2017

Honestly, this just seems like something we should do in 6.0. I didn't realize it was already firing deprecation notices in Elasticsearch.

@lukasolson lukasolson mentioned this issue Jul 28, 2017
Closed
@lukasolson lukasolson added Feature:Highlight Highlighting of content via query PR sent labels Jul 28, 2017
@lukasolson lukasolson self-assigned this Jul 28, 2017
@lukasolson lukasolson mentioned this issue Jul 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
blocker chore Feature:Highlight Highlighting of content via query PR sent v7.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@epixa @lukasolson @Bargs