Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Session view UI polish based on the QA notes #127992

Closed
11 of 21 tasks
Tracked by #126054
animehart opened this issue Mar 17, 2022 · 3 comments · Fixed by #128188
Closed
11 of 21 tasks
Tracked by #126054

[Security Solution] Session view UI polish based on the QA notes #127992

animehart opened this issue Mar 17, 2022 · 3 comments · Fixed by #128188
Assignees
Labels
Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution

Comments

@animehart
Copy link
Contributor

animehart commented Mar 17, 2022

Background

Some of the UI props on Session view page needs to be updated to follow the latest Figma design. The list of the changes required are listed on the QA Notes ( https://www.figma.com/file/3v90FFYIKKZ7aIPxj2fxiH/%5B8.2%5D-%5BSession-viewer%5D-Session-View-for-Sessions-and-Processes?node-id=1885%3A361276 )

Tasks

Detail panel

➡️ Link to Figma file

  • Detail Panels sizing: Default size: 25% of viewport, but no less than 320 px. Max size: 40% of viewport ➡️ Link to Figma file QA
  • Fix typography in Detail Items
  • Detail Items height: 32 px
  • Fix spacing between Items
  • Fix padding between last Item and next section. Should be 16 px
  • Add Border-left to Details Panel Border-left box-shadow: 1px 0px 0px 0px #D3DAE6 inset;
  • Fix button states for Detail Panel ➡️ Toggle button specs in EUI
  • In a case when the row has a multiple values, we display first 5 and the link 'Show more'. After clicking on this link we expand all list of values and link copy changed to 'Show less' ➡️ Link to Figma file QA

Toolbar

Find results interaction

  • Highlighted findings specs: Selected state: $euiColorWarning, Default state: $euiColorWarning 32% opacity
  • No border-radius for highlight
  • Jump to findings below the viewport should scroll the session viewer content
  • There is an issue with a long text in the search field. It overlaps with stepper-control. Text should go under stepper control. Example EuiFieldSearch https://codesandbox.io/s/hz7boq?file=/demo.js

Session viewer frame

@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 17, 2022
@animehart animehart added the Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution label Mar 17, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 17, 2022
@codearos
Copy link

Details panel QA

➡️ Link to Figma file

Panel component specs

Default width: 360 px. For resize states: Min width: 320 px; Max width: 640 px;

Frame 2002

Item specs

Frame 1996

Button states

For Detal Panel btn used EuiButton toggle.
https://elastic.github.io/eui/#:~:text=Props-,Toggle%20buttons,-You%20can%20create

Mockup 2

@codearos
Copy link

Find results interaction

Screen.Recording.2022-03-21.at.2.55.51.PM.mov

@animehart animehart linked a pull request Mar 21, 2022 that will close this issue
20 tasks
@codearos codearos self-assigned this Mar 22, 2022
@codearos
Copy link

Detail Panels sizing

Default size: 25% of viewport, but no less than 320 px. Max size: 40% of viewport.

➡️ Link to Figma file QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants