Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Change toolbar popovers' disabled form rows to hidden instead #126469

Closed
MichaelMarcialis opened this issue Feb 28, 2022 · 1 comment · Fixed by #129994
Closed

[Lens] Change toolbar popovers' disabled form rows to hidden instead #126469

MichaelMarcialis opened this issue Feb 28, 2022 · 1 comment · Fixed by #129994
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@MichaelMarcialis
Copy link
Contributor

Per my previous comments, seeing as the settings within the Lens toolbar popovers continue to grow more robust and complex, I think now is a good time to revisit my previous suggestion to "disable form fields when the user has the ability to enable them in the current context." While that approach works in simpler situations (where there is a desire to showcase all available features to users), I worry that it is now becoming too cluttered and visually noisy for the user to be presented with so many disabled fields that they have to stumble past.

Can we transition the form rows that are currently being disabled in these toolbar popovers from being disabled to now be hidden instead, only showing them when they available (as we've begun doing in the configuration flyouts, per the latest annotation designs)?

image

@MichaelMarcialis MichaelMarcialis added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants