Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] better documentation on proxyHeaders config #124250

Open
pmuellr opened this issue Feb 1, 2022 · 4 comments
Open

[ResponseOps] better documentation on proxyHeaders config #124250

pmuellr opened this issue Feb 1, 2022 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience docs Feature:Actions/Framework Issues related to the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Feb 1, 2022

Kibana version: 8.0.0

The documentation of the action config xpack.actions.proxyHeaders is a little misleading. When looking at the code, it's only used in a few situations:

  • https proxy, but not http proxy for all connectors but email
  • https and http proxy for email

I don't think this is neccessarily a bug - http and https proxies are wildly different protocols, it's not clear to me there's a general way to send a proxy headers that aren't passed onto the proxied service for http.

So we should at least document the current behavior.

@pmuellr pmuellr added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/Framework Issues related to the Actions Framework labels Feb 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@pmuellr
Copy link
Member Author

pmuellr commented Feb 17, 2022

see also: #125837

@mikecote
Copy link
Contributor

@pmuellr have we improved this area recently with another issue?

@pmuellr
Copy link
Member Author

pmuellr commented Sep 26, 2022

Not that I know of. But I added it to the proxy TODO issue #138319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience docs Feature:Actions/Framework Issues related to the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

3 participants