Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Table Allow for Filtering of Rows on the string Column Value(s) #122170

Closed
Tracked by #184648 ...
BenB196 opened this issue Dec 30, 2021 · 10 comments
Closed
Tracked by #184648 ...

[Lens] Table Allow for Filtering of Rows on the string Column Value(s) #122170

BenB196 opened this issue Dec 30, 2021 · 10 comments
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@BenB196
Copy link

BenB196 commented Dec 30, 2021

Describe the feature:

With rows in Lens table, it is currently only possible to filter via an Elasticsearch filter. This has a downside of not being able to filter by the generated column values. It would be nice if you could add filters directly to tables after they have been constructed.

(I recognize that this might enter the realm of multi-part queries if you only use ES, which from my understanding currently isn't possible)

Describe a specific use case for the feature:

Lets say I have a table that looks like the below:

Thing Count of Thing
Dog 10
Car 20
Chair 5

In Excel I can do things like filter column:

  • Thing to only show Dog.
  • I can filter to only show rows where Thing starts with the letter C (Car and Chair).
    • Note that this currently isn't possible if you have documents structured like:
{
  "_source": {
    "Thing": ["Dog", "Car"]
  }
  "_source": {
    "Thing": ["Chair", "Car"]
  }
  "_source": {
    "Thing": ["Chair", "Dog"]
  }
}
  • As Elasticsearch filtering will return all values of the array. And you will get a row with Dog with count of 2

I can also filter to show only rows with the column value:

  • Count of Thing > 7.
  • This can be achieved in Lens with custom formulas from what I can tell, but this is not ideal for end users who shouldn't be required to know how to edit visualizations.
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 30, 2021
@BenB196 BenB196 changed the title [Lens] Table Allow for Filtering of Column on the Column (after the Elasticsearch query) [Lens] Table Allow for Filtering of Rows on the Column Value(s) Dec 30, 2021
@dej611 dej611 added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 30, 2021
@dej611 dej611 added the enhancement New value added to drive a business result label Dec 30, 2021
@flash1293
Copy link
Contributor

Duplicate of #86190

@flash1293 flash1293 marked this as a duplicate of #86190 Jan 4, 2022
@BenB196
Copy link
Author

BenB196 commented Jan 4, 2022

@flash1293 I'm not sure if the issue you linked as a duplicate is a true duplicate. While I think it might cover the second use-case:

I can also filter to show only rows with the column value:
Count of Thing > 7.

I don't think it covers the first use-case of being able to filter by the any column, as it seems like the issue you linked is just for numbers, where the first use-case is for text-based column.

Unless this closure is saying there are no plans to add this feature for text.

@flash1293
Copy link
Contributor

flash1293 commented Jan 4, 2022

@BenB196 Good point - I think this use case is covered by the include/exclude parameters of the terms aggregation. These are not supported in Lens yet (they are available in Visualize), but there's a separate issue here: #96585

Would that cover your use case?

@BenB196
Copy link
Author

BenB196 commented Jan 4, 2022

@flash1293 yes, after looking into it seems like include/exclude parameters would cover the use case here. Though it looks like the old aggregation table won't support my use case, as my table uses Metrics with Filter By's which don't seem to be supported in the old viz's.

Though one thing I would like to see that I don't see in either ticket, is being able to apply the filter adhoc in the visualization itself, so that an end user doesn't need to edit the visualization. Possibly in the table column drop-down:
image
Have an additional Filter By section, kind of like Excel:

image

@flash1293
Copy link
Contributor

@BenB196 makes sense, I will reopen, thanks for explaining.

@flash1293 flash1293 reopened this Jan 5, 2022
@flash1293 flash1293 changed the title [Lens] Table Allow for Filtering of Rows on the Column Value(s) [Lens] Table Allow for Filtering of Rows on the string Column Value(s) Jan 5, 2022
@gueri-fr
Copy link

gueri-fr commented Nov 3, 2022

+1

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jan 23, 2023
@smnschneider
Copy link
Contributor

+1

1 similar comment
@brynnhart
Copy link

+1

@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 28, 2023
@markov00
Copy link
Member

markov00 commented Jun 3, 2024

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box, solvable possibly with ESQL #184648

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

10 participants