Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana needs to display actionable warning with details #116709

Closed
bhavyarm opened this issue Oct 28, 2021 · 10 comments
Closed

Kibana needs to display actionable warning with details #116709

bhavyarm opened this issue Oct 28, 2021 · 10 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Scripted Fields Scripted fields features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 28, 2021

Kibana version: 7.16.0/7.15.x

Elasticsearch version: 7.16.0/7.15.x

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you upgrade with flights sample data from 6.8 - to 7.15.x/7.16 - Kibana displays the following message on sample flight data dashboard and discover. But there are no details about where and how to fix this.
"
Warning: 299 Elasticsearch-7.16.0-51c82bcb077f146021909e0978694b6b9b205f36 "Use of the joda time method [getHourOfDay()] is deprecated. Use [getHour()] instead."
"

This is coming from the scripted field "hour_of_day" on flights data which is defined as

doc['timestamp'].value.hourOfDay

We should display the details about this to the user - so user can change it. If not - suppress the warning so its not confusing.

Screen Shot 2021-10-28 at 4 41 16 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Scripted Fields Scripted fields features Team:AppServicesSv and removed Team:AppServicesUx labels Oct 28, 2021
@rashmivkulkarni
Copy link
Contributor

@elastic/kibana-app-services

@liza-mae
Copy link
Contributor

Duplicate of #111654 resolution details are here #111654 (comment)

@liza-mae
Copy link
Contributor

Those warnings are coming from Elasticsearch, so not sure anything can/should be done from Kibana. There is some documentation on the method here https://www.elastic.co/guide/en/elasticsearch/painless/7.16/painless-api-reference-shared-org-elasticsearch-script.html.

@Dosant
Copy link
Contributor

Dosant commented Oct 29, 2021

I think there are a couple of small things we can do in Kibana to improve search service warnings in general and make them easier to debug:

  1. Currently it is not clear which search triggered a warning, this is especially annoying on a dashboard with multiple panels. Maybe we should print executionContext as part of the warning which should give a hint where the search came from
  2. I think we should add this warning inside the inspector. Users will be able to go through run searches and find the one that caused the warning

@cjcenizal
Copy link
Contributor

This was fixed for fresh installs of sample data in 7.15 and after via #108825. But the problem is that for users who installed the sample data prior to 7.15, their data still depends upon a deprecation ES feature.

@lukasolson I think what we need is a saved object migration, so if a user has sample data installed it gets migrated from the deprecated feature to the supported feature.

@cjcenizal
Copy link
Contributor

cjcenizal commented Nov 2, 2021

@bhavyarm Could you please reproduce this in 7.16 and let me know if you see this same 299 joda deprecation message appear in the deprecation logs, which you can access from Upgrade Assistant?

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Nov 3, 2021

@cjcenizal yes I did reproduce it in 7.16.0 BC2 and this is what I see in upgrade assistant -
Screen Shot 2021-11-03 at 1 01 32 PM

@cjcenizal
Copy link
Contributor

Thanks @bhavyarm! The screenshot you showed is for deprecation issues, which is different from deprecation logs. On the Upgrade Assistant home page, there is a section for deprecation logging. You might need to enable it, and then revisit the troublesome dashboard to trigger the errors again. At that point, if you go back to Upgrade Assistant and review the deprecation logs in the Logs UI, I'm hoping you'll see logs that contain the same error you saw in Dashboard.

@lukasolson
Copy link
Member

We are removing the warning in #117252. We will circle back to figure out more helpful ways to inform the user about deprecations.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 18, 2021
@exalate-issue-sync exalate-issue-sync bot changed the title Kibana needs to display actionable warning with details Kibana needs to display actionable warning with details Dec 14, 2021
@mattkime
Copy link
Contributor

Closing as the warning is no longer displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Scripted Fields Scripted fields features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

7 participants