Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Use EuiSelectable for field picker #116189

Closed
andreadelrio opened this issue Oct 25, 2021 · 5 comments
Closed

[Controls] Use EuiSelectable for field picker #116189

andreadelrio opened this issue Oct 25, 2021 · 5 comments
Labels
Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@andreadelrio
Copy link
Contributor

We need to update the field picker in Controls to use EuiSelectable. The field list in Discover/Lens wasn't really designed to be placed inside a container with limited height which in turn will be inside a flyout. Using EuiSelectable will give us a much more compact field list and the check feels cleaner than the blue outline.

euiSelectable_fieldList1

euiSelectable_fieldList_vs

Related to #115991
@andreadelrio andreadelrio added Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Controls labels Oct 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

When using EuiSelectable, is the field list always present? Or is it part of a popover on click?

@andreadelrio
Copy link
Contributor Author

When using EuiSelectable, is the field list always present? Or is it part of a popover on click?

It is always present

@ThomThomson
Copy link
Contributor

Awesome, I think that's the right way to do this - should be a quick change!

@Heenawter Heenawter added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 12, 2023
@Heenawter
Copy link
Contributor

Closed by #151231 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andreadelrio @Heenawter @ThomThomson @elasticmachine