Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add support for installing tag saved objects #110660

Closed
joshdover opened this issue Aug 31, 2021 · 2 comments
Closed

[Fleet] Add support for installing tag saved objects #110660

joshdover opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0

Comments

@joshdover
Copy link
Contributor

Fleet integrations are planning to add tags to installed Kibana assets like Dashboard and Visualizations to identify the specific integration they're related to and to tag them as "managed" by the system elastic/integrations#327

We need to add support to the EPM installation and upgrade code to support install these SO types.

On the client side it's recommended to use the SavedObjectTagging client instead of the default SavedObjectsClient, but there currently is no analog API for the server-side. @pgayvallet any reason we'd have problems with using the regular SOC.bulkCreate or SOC.import APIs for this use case?

@joshdover joshdover added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@pgayvallet
Copy link
Contributor

On the client side it's recommended to use the SavedObjectTagging client instead of the default SavedObjectsClient, but there currently is no analog API for the server-side

I didn't add it because it wasn't required when we initially implemented tagging, but we could easily expose the TagsClient from the server-side savedObjectTagging's start contract if necessary.

any reason we'd have problems with using the regular SOC.bulkCreate or SOC.import APIs for this use case?

The main upside of using the dedicated client is the validation performed on the tag's property. Now, the tag client isn't doing any kind of transformations, so using bulkCreate should be fine.

Also , import is already used to import tags from SOM (as the type is exportable), so you wouldn't be doing anything new by leveraging this API.

In short: imho it's fine to use bulkCreate or import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0
Projects
None yet
Development

No branches or pull requests

5 participants