Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUI Sass Variables Refactor #11032

Closed
8 tasks
snide opened this issue Apr 5, 2017 · 0 comments
Closed
8 tasks

KUI Sass Variables Refactor #11032

snide opened this issue Apr 5, 2017 · 0 comments
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@snide
Copy link
Contributor

snide commented Apr 5, 2017

Describe the feature:

KUI has some inconsistencies with namespacing and global variables that lead to variances in our colors, spacing, theming and fonts. I'd like to try and attack the following as a means to get it more consumable for development.

  • Proper variable scoping ($global vs. $component) [UI Framework] KUI sass variable namespacing / rework #11033
  • Consolidate the color palette into some core colors.
  • Consolidate our font-sizing and weights to some defined options.
  • Consolidate our spacing and padding to some defined options.
  • Consolidate our border usage to some defined options.
  • Consolidate our box-shadows to some defined options.
  • Remove any variable bleed (named variables that aren't global that are used in multiple components).
  • Use a mixin system for declaring BEM namespacing to avoid cascade / naming errors.

Likely this will take several PRs in parts, so attaching it to the meta tag. cc @cjcenizal who I've talked a bit about with this.

@snide snide added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Meta labels Apr 5, 2017
@cjcenizal cjcenizal mentioned this issue Jul 12, 2017
51 tasks
@snide snide closed this as completed Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

1 participant