Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Data grid alert does not account for header height when in full screen mode #108896

Closed
snide opened this issue Aug 17, 2021 · 6 comments · Fixed by elastic/eui#5054
Closed

[Security Solution] Data grid alert does not account for header height when in full screen mode #108896

snide opened this issue Aug 17, 2021 · 6 comments · Fixed by elastic/eui#5054
Assignees
@michaelolo24
Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0

Comments

@snide
Copy link
Contributor

snide commented Aug 17, 2021

Flyout is misaligned in full screen mode because it think the header height is still there. Likely needs to be accounted for with some css when it's in this state.

image
@snide snide added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: rac label obsolete labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team triage_needed labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@XavierM
Copy link
Contributor

XavierM commented Aug 18, 2021

I think we should find a global solution because it is also happening in discover too. Maybe when the flyout start to open it can check if it is coming from a full screen and not apply the top height

image

@XavierM
Copy link
Contributor

XavierM commented Aug 18, 2021

In the mean time, we can check the css to see if this class euiDataGrid--fullScreen is on and overwrite the class .kbnBody.euiBody--headerIsFixed .euiFlyout to not apply the top and height

@snide
Copy link
Contributor Author

snide commented Aug 18, 2021

Agreed about making it global. I made discover an issue for it as well when I made this one. #108681

@snide snide mentioned this issue Aug 18, 2021
Closed
@MichaelMarcialis
Copy link
Contributor

FYI, I believe I have a fix that can be implemented globally on the EUI side for both this and the Discover issue (original comment). Will cut an EUI PR today.

@MichaelMarcialis MichaelMarcialis mentioned this issue Aug 19, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelolo24 michaelolo24

Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0
Projects
None yet
Milestone
No milestone
7 participants
@XavierM @snide @MichaelMarcialis @elasticmachine @michaelolo24 @MadameSheema @asnehalb