Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsearch] repetitive uiSettings access on each search #108062

Closed
spalger opened this issue Aug 10, 2021 · 2 comments · Fixed by #114088
Closed

[bsearch] repetitive uiSettings access on each search #108062

spalger opened this issue Aug 10, 2021 · 2 comments · Fixed by #114088
Assignees
Labels
Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@spalger
Copy link
Contributor

spalger commented Aug 10, 2021

Kibana version: master
Elasticsearch version: master
Server OS version: CI

Description of the problem including expected versus actual behavior: When bsearch receives multiple search requests for strategy ese_search I'm noticing that every query makes its own call to uiSettingsClient.get(UI_SETTINGS.SEARCH_INCLUDE_FROZEN), which results in many unnecessary requests being fired of to ES at the same time:

kibana-ops-journeys-apm kb us-west1 gcp cloud es io_9243_app_apm_services_kibana_transactions_view_rangeFrom=2021-08-10T11_49_15 258Z rangeTo=2021-08-10T11_52_08 810Z environment=ci transactionName=POST%20%2Finternal%2Fbsearch transacti (1)

Steps to reproduce:

  1. Run Kibana with APM enabled
  2. Load up a dashboard with multiple visualizations
  3. Checkout the APM data to find POST /internal/bsearch transactions, then flip through them and see that they send many requests to ES for the same document at the same time.
@spalger spalger added Feature:Search Querying infrastructure in Kibana Team:AppServices labels Aug 10, 2021
@spalger
Copy link
Contributor Author

spalger commented Aug 10, 2021

Location of the mentioned call:

const includeFrozen = await uiSettingsClient.get(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 12, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 28, 2021
@Dosant Dosant self-assigned this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants