Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/Tech Debt] Return objects in Job APIs are inconsistent #104791

Closed
tsullivan opened this issue Jul 8, 2021 · 2 comments · Fixed by #105508
Closed

[Reporting/Tech Debt] Return objects in Job APIs are inconsistent #104791

tsullivan opened this issue Jul 8, 2021 · 2 comments · Fixed by #105508
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label technical debt Improvement of the software architecture and operational architecture

Comments

@tsullivan
Copy link
Member

tsullivan commented Jul 8, 2021 •
edited
Loading

Kibana version: 5.0+

The job routes in Kibana reporting return different "flavor" of objects:

  • info/<jobId>: returns ReportApiJSON
  • list: returns ReportDocument

This causes various components under reporting/management to use different shapes of objects in props, making refactoring and reasoning the code difficult - namely the "button" components in x-pack/plugins/reporting/public/management

Intersects with #102833
@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Jul 8, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 8, 2021
@tsullivan tsullivan added Team:AppServices technical debt Improvement of the software architecture and operational architecture labels Jul 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 8, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 8, 2021
@tsullivan tsullivan mentioned this issue Jul 13, 2021
Merged
2 tasks
@sophiec20 sophiec20 added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Clean up types for internal APIs needed for UI tsullivan/kibana
3 participants
@tsullivan @sophiec20 @elasticmachine