Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve Lens embeddable error handling #104395

Closed
Tracked by #57706
flash1293 opened this issue Jul 6, 2021 · 3 comments
Closed
Tracked by #57706

[Lens] Improve Lens embeddable error handling #104395

flash1293 opened this issue Jul 6, 2021 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Right now, an exception thrown during expression generation results in an uncaught exception and a blank panel without further information.

Instead, this error should be caught and rendered as a regular error like a configuration not validating properly, with appropriate data-render-error and data-render-complete attributes.

See #103561

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@drewdaemon
Copy link
Contributor

I think we could

  1. wrap the expression building in a try catch and return the error from the persistedStateToExpressionFunction
  2. display an error via this.addUserMessage on the embeddable side

@drewdaemon drewdaemon added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 9, 2023
@stratoula
Copy link
Contributor

Closing in favor of #144224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants