chore: use explicit update calls instead of helper functions

elastic · Jun 14, 2019 · ff5cede · ff5cede
1 parent f8ae279
commit ff5cede
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/...acy/core_plugins/dashboard_embeddable_container/public/embeddable/dashboard_container.tsx b/...acy/core_plugins/dashboard_embeddable_container/public/embeddable/dashboard_container.tsx
@@ -100,20 +100,6 @@ export class DashboardContainer extends Container<InheritedChildInput, Dashboard
     return createPanelState(panelState, Object.values(this.input.panels));
   }
 
-  public onPanelsUpdated = (panels: { [panelId: string]: DashboardPanelState }) => {
-    this.updateInput({
-      panels: {
-        ...panels,
-      },
-    });
-  };
-
-  public onExitFullScreenMode = () => {
-    this.updateInput({
-      isFullScreenMode: false,
-    });
-  };
-
   public render(dom: HTMLElement) {
     ReactDOM.render(
       // @ts-ignore - hitting https://github.com/DefinitelyTyped/DefinitelyTyped/issues/27805

diff --git a/...acy/core_plugins/dashboard_embeddable_container/public/embeddable/grid/dashboard_grid.tsx b/...acy/core_plugins/dashboard_embeddable_container/public/embeddable/grid/dashboard_grid.tsx
@@ -215,7 +215,9 @@ class DashboardGridUi extends React.Component<DashboardGridProps, State> {
   };
 
   public onPanelsUpdated = (panels: { [key: string]: DashboardPanelState }) => {
-    this.props.container.onPanelsUpdated(panels);
+    this.props.container.updateInput({
+      panels,
+    });
   };
 
   public onPanelFocused = (focusedPanelIndex: string): void => {

diff --git a/..._plugins/dashboard_embeddable_container/public/embeddable/viewport/dashboard_viewport.tsx b/..._plugins/dashboard_embeddable_container/public/embeddable/viewport/dashboard_viewport.tsx
@@ -77,7 +77,9 @@ export class DashboardViewport extends React.Component<DashboardViewportProps, S
   }
 
   public onExitFullScreenMode = () => {
-    this.props.container.onExitFullScreenMode();
+    this.props.container.updateInput({
+      isFullScreenMode: false,
+    });
   };
 
   public render() {