Skip to content

Commit

Permalink
GoodBye Notifier (#41663)
Browse files Browse the repository at this point in the history
* Begin notifier removal

* Remove remaining notifier traces

* Remove dead translations

* Remove Angular from config listener

* Import angular-sanitize explicitly in map
  • Loading branch information
Tim Roes committed Jul 23, 2019
1 parent a6fd0c3 commit e1bc154
Show file tree
Hide file tree
Showing 31 changed files with 9 additions and 952 deletions.
1 change: 0 additions & 1 deletion docs/plugins/known-plugins.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ This list of plugins is not guaranteed to work on your version of Kibana. Instea
[float]
=== Other
* https://github.com/nreese/kibana-time-plugin[Time picker as a dashboard panel] Widget to view and edit the time range from within dashboards.
* https://github.com/sw-jung/kibana_notification_center[Notification Center] (sw-jung) - for better experience of notifier toasts.

* https://github.com/Webiks/kibana-API.git[Kibana-API] (webiks) Exposes an API with Kibana functionality.
Use it to create, edit and embed visualizations, and also to search inside an embedded dashboard.
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/context/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const module = uiModules.get('apps/context', [
'elasticsearch',
'kibana',
'kibana/config',
'kibana/notify',
'ngRoute',
]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ const fetchStatuses = {
};

const app = uiModules.get('apps/discover', [
'kibana/notify',
'kibana/courier',
'kibana/url',
'kibana/index_patterns'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import { createLegacyClass } from 'ui/utils/legacy_class';
import { SavedObjectProvider } from 'ui/saved_objects/saved_object';

const module = uiModules.get('discover/saved_searches', [
'kibana/notify',
'kibana/courier'
]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ import 'ui/notify';
import { uiModules } from 'ui/modules';
import { SavedObjectLoader, SavedObjectsClientProvider } from 'ui/saved_objects';
import { savedObjectManagementRegistry } from '../../management/saved_object_registry';
const module = uiModules.get('discover/saved_searches', [
'kibana/notify'
]);
const module = uiModules.get('discover/saved_searches');

// Register this service with the saved object registry so it can be
// edited by the object editor.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import 'plugins/kibana/doc_viewer';
import { getRootBreadcrumbs } from 'plugins/kibana/discover/breadcrumbs';

const app = uiModules.get('apps/doc', [
'kibana/notify',
'kibana/courier',
'kibana/index_patterns'
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ uiRoutes

uiModules
.get('app/visualize', [
'kibana/notify',
'kibana/url'
])
.directive('visualizeApp', function () {
Expand Down
4 changes: 0 additions & 4 deletions src/legacy/ui/public/chrome/directives/kbn_chrome.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<div class="app-wrapper-panel">
<kbn-notifications
list="notifList"
></kbn-notifications>

<div id="globalBannerList"></div>

<div
Expand Down
4 changes: 0 additions & 4 deletions src/legacy/ui/public/chrome/directives/kbn_chrome.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { uiModules } from '../../modules';
import template from './kbn_chrome.html';

import {
notify,
GlobalBannerList,
banners,
} from '../../notify';
Expand Down Expand Up @@ -58,9 +57,6 @@ export function kbnChromeProvider(chrome, internals) {

controllerAs: 'chrome',
controller($scope, $location, Private) {
// Notifications
$scope.notifList = notify._notifs;

$scope.getFirstPathSegment = () => {
return $location.path().split('/')[1];
};
Expand Down
114 changes: 0 additions & 114 deletions src/legacy/ui/public/directives/__tests__/truncate.js

This file was deleted.

165 changes: 0 additions & 165 deletions src/legacy/ui/public/notify/__tests__/notifier.js

This file was deleted.

1 change: 0 additions & 1 deletion src/legacy/ui/public/notify/_index.scss
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@import './banners/index';
@import './partials/index';
Loading

0 comments on commit e1bc154

Please sign in to comment.