From d3818485dccf6a3a65602cff1d2833b99dcc7e77 Mon Sep 17 00:00:00 2001 From: Philippe Oberti Date: Fri, 6 Oct 2023 15:33:40 -0500 Subject: [PATCH] [Security Solution] remove unused flyoutSize property (#167096) --- .../case_view/components/case_view_alerts.test.tsx | 2 -- .../components/case_view/components/case_view_alerts.tsx | 2 -- .../hosts/components/tabs/alerts/alerts_tab_content.tsx | 1 - x-pack/plugins/observability/public/pages/alerts/alerts.tsx | 1 - .../observability/public/pages/overview/overview.tsx | 1 - .../pages/rule_details/components/rule_details_tabs.tsx | 1 - .../pages/slo_details/components/slo_detail_alerts.tsx | 1 - .../rule_details_ui/pages/rule_details/index.tsx | 1 - .../public/detections/components/alerts_table/index.tsx | 6 +----- .../detections/pages/detection_engine/detection_engine.tsx | 1 - .../risk_score/top_risk_score_contributors_alerts/index.tsx | 1 - .../sections/alerts_table/alerts_flyout/alerts_flyout.tsx | 5 +---- .../sections/alerts_table/alerts_table_state.tsx | 5 ----- x-pack/plugins/triggers_actions_ui/public/types.ts | 2 -- 14 files changed, 2 insertions(+), 28 deletions(-) diff --git a/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.test.tsx b/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.test.tsx index a89148b4f29078..a552480fb08888 100644 --- a/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.test.tsx +++ b/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.test.tsx @@ -53,7 +53,6 @@ describe('CaseUI View Page activity tab', () => { values: ['alert-id-1'], }, }, - flyoutSize: 'm', showExpandToDetails: true, showAlertStatusWithFlapping: false, }); @@ -83,7 +82,6 @@ describe('CaseUI View Page activity tab', () => { values: ['alert-id-1'], }, }, - flyoutSize: 's', showExpandToDetails: false, showAlertStatusWithFlapping: true, }); diff --git a/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.tsx b/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.tsx index e3393bf7f35446..4c8872d5fbd3fe 100644 --- a/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.tsx +++ b/x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.tsx @@ -7,7 +7,6 @@ import React, { useMemo } from 'react'; -import type { EuiFlyoutSize } from '@elastic/eui'; import { EuiFlexItem, EuiFlexGroup, EuiProgress } from '@elastic/eui'; import { SECURITY_SOLUTION_OWNER } from '../../../../common/constants'; import type { CaseUI } from '../../../../common'; @@ -47,7 +46,6 @@ export const CaseViewAlerts = ({ caseData }: CaseViewAlertsProps) => { alertsTableConfigurationRegistry: triggersActionsUi.alertsTableConfigurationRegistry, configurationId: configId, id: `case-details-alerts-${caseData.owner}`, - flyoutSize: (alertFeatureIds?.includes('siem') ? 'm' : 's') as EuiFlyoutSize, featureIds: alertFeatureIds ?? [], query: alertIdsQuery, showExpandToDetails: Boolean(alertFeatureIds?.includes('siem')), diff --git a/x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx b/x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx index 9913f11b20cc9b..7ccd5b849e598f 100644 --- a/x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx +++ b/x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx @@ -51,7 +51,6 @@ export const AlertsTabContent = () => { alertsTableConfigurationRegistry={alertsTableConfigurationRegistry} configurationId={AlertConsumers.OBSERVABILITY} featureIds={infraAlertFeatureIds} - flyoutSize="s" id={ALERTS_TABLE_ID} pageSize={ALERTS_PER_PAGE} query={alertsEsQueryByStatus} diff --git a/x-pack/plugins/observability/public/pages/alerts/alerts.tsx b/x-pack/plugins/observability/public/pages/alerts/alerts.tsx index 01a1346b733431..e02eae9de36167 100644 --- a/x-pack/plugins/observability/public/pages/alerts/alerts.tsx +++ b/x-pack/plugins/observability/public/pages/alerts/alerts.tsx @@ -224,7 +224,6 @@ function InternalAlertsPage() { alertsTableConfigurationRegistry={alertsTableConfigurationRegistry} configurationId={AlertConsumers.OBSERVABILITY} id={ALERTS_TABLE_ID} - flyoutSize="s" featureIds={observabilityAlertFeatureIds} query={esQuery} showExpandToDetails={false} diff --git a/x-pack/plugins/observability/public/pages/overview/overview.tsx b/x-pack/plugins/observability/public/pages/overview/overview.tsx index 16bf0a25215ce4..7c1296ee15e93a 100644 --- a/x-pack/plugins/observability/public/pages/overview/overview.tsx +++ b/x-pack/plugins/observability/public/pages/overview/overview.tsx @@ -188,7 +188,6 @@ export function OverviewPage() { = ({ return ( ` `; interface DetectionEngineAlertTableProps { configId: string; - flyoutSize: EuiFlyoutSize; inputFilters: Filter[]; tableId: TableId; sourcererScope?: SourcererScopeName; @@ -96,7 +95,6 @@ interface DetectionEngineAlertTableProps { export const AlertsTableComponent: FC = ({ configId, - flyoutSize, inputFilters, tableId = TableId.alertsOnAlertsPage, sourcererScope = SourcererScopeName.detections, @@ -258,7 +256,6 @@ export const AlertsTableComponent: FC = ({ configurationId: configId, // stores saperate configuration based on the view of the table id: `detection-engine-alert-table-${configId}-${tableView}`, - flyoutSize, featureIds: ['siem'], query: finalBoolQuery, showExpandToDetails: false, @@ -278,7 +275,6 @@ export const AlertsTableComponent: FC = ({ triggersActionsUi.alertsTableConfigurationRegistry, configId, tableView, - flyoutSize, finalBoolQuery, gridStyle, rowHeightsOptions, diff --git a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx index bfaea325184592..5291c5326ae3f7 100644 --- a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx +++ b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx @@ -382,7 +382,6 @@ const DetectionEnginePageComponent: React.FC = ({ return ( diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_flyout/alerts_flyout.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_flyout/alerts_flyout.tsx index 601c22c2624a5c..a25af7cb5386e0 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_flyout/alerts_flyout.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_flyout/alerts_flyout.tsx @@ -14,7 +14,6 @@ import { EuiFlexItem, EuiPagination, EuiProgress, - EuiFlyoutSize, } from '@elastic/eui'; import type { Alert, AlertsTableConfigurationRegistry } from '../../../../types'; @@ -40,7 +39,6 @@ interface AlertsFlyoutProps { alert: Alert; alertsTableConfiguration: AlertsTableConfigurationRegistry; flyoutIndex: number; - flyoutSize?: EuiFlyoutSize; alertsCount: number; isLoading: boolean; onClose: () => void; @@ -51,7 +49,6 @@ export const AlertsFlyout: React.FunctionComponent = ({ alert, alertsTableConfiguration, flyoutIndex, - flyoutSize = 'm', alertsCount, isLoading, onClose, @@ -109,7 +106,7 @@ export const AlertsFlyout: React.FunctionComponent = ({ ); return ( - + {isLoading && } diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table_state.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table_state.tsx index 1b4b40b7317b79..b99e95e3e0881e 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table_state.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table_state.tsx @@ -12,7 +12,6 @@ import { EuiProgress, EuiDataGridSorting, EuiEmptyPrompt, - EuiFlyoutSize, EuiDataGridProps, EuiDataGridToolBarVisibilityOptions, } from '@elastic/eui'; @@ -64,7 +63,6 @@ export type AlertsTableStateProps = { configurationId: string; id: string; featureIds: ValidFeatureId[]; - flyoutSize?: EuiFlyoutSize; query: Pick; pageSize?: number; showExpandToDetails: boolean; @@ -148,7 +146,6 @@ const AlertsTableStateWithQueryProvider = ({ configurationId, id, featureIds, - flyoutSize, query, pageSize, showExpandToDetails, @@ -378,7 +375,6 @@ const AlertsTableStateWithQueryProvider = ({ bulkActions: [], deletedEventIds: [], disabledCellActions: [], - flyoutSize, pageSize: pagination.pageSize, pageSizeOptions: [10, 20, 50, 100], id, @@ -409,7 +405,6 @@ const AlertsTableStateWithQueryProvider = ({ memoizedCases, memoizedMaintenanceWindows, columns, - flyoutSize, pagination.pageSize, id, leadingControlColumns, diff --git a/x-pack/plugins/triggers_actions_ui/public/types.ts b/x-pack/plugins/triggers_actions_ui/public/types.ts index 460a621918cfe2..d75f3d7920241b 100644 --- a/x-pack/plugins/triggers_actions_ui/public/types.ts +++ b/x-pack/plugins/triggers_actions_ui/public/types.ts @@ -15,7 +15,6 @@ import type { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public'; import type { UnifiedSearchPublicPluginStart } from '@kbn/unified-search-plugin/public'; import type { IconType, - EuiFlyoutSize, RecursivePartial, EuiDataGridCellValueElementProps, EuiDataGridToolBarAdditionalControlsOptions, @@ -538,7 +537,6 @@ export type AlertsTableProps = { // defaultCellActions: TGridCellAction[]; deletedEventIds: string[]; disabledCellActions: string[]; - flyoutSize?: EuiFlyoutSize; pageSize: number; pageSizeOptions: number[]; id?: string;