diff --git a/test/plugin_functional/test_suites/data_plugin/session.ts b/test/plugin_functional/test_suites/data_plugin/session.ts index c44e606aa2d042..773664da7510e0 100644 --- a/test/plugin_functional/test_suites/data_plugin/session.ts +++ b/test/plugin_functional/test_suites/data_plugin/session.ts @@ -23,28 +23,33 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide const toasts = getService('toasts'); const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); + const retry = getService('retry'); + const browser = getService('browser'); const getSessionIds = async () => { const sessionsBtn = await testSubjects.find('showSessionsButton'); await sessionsBtn.click(); const toast = await toasts.getElementByIndex(1); const sessionIds = await toast.getVisibleText(); + await toasts.dismissAll(); return sessionIds.split(','); }; - // Failing: See https://github.com/elastic/kibana/issues/192510 - // Failing: See https://github.com/elastic/kibana/issues/192510 - describe.skip('Session management', function describeSessionManagementTests() { + const clearSessionIds = async () => { + await testSubjects.click('clearSessionsButton'); + await toasts.dismissAll(); + }; + + describe('Session management', function describeSessionManagementTests() { describe('Discover', () => { before(async () => { await common.navigateToApp('discover'); - await testSubjects.click('clearSessionsButton'); + await clearSessionIds(); await header.waitUntilLoadingHasFinished(); }); afterEach(async () => { - await testSubjects.click('clearSessionsButton'); - await toasts.dismissAll(); + await clearSessionIds(); }); it('Starts on index pattern select', async () => { @@ -93,8 +98,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide }); afterEach(async () => { - await testSubjects.click('clearSessionsButton'); - await toasts.dismissAll(); + await clearSessionIds(); }); after(async () => { @@ -115,6 +119,19 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide }); it('starts a session on filter change', async () => { + // For some reason, when loading the dashboard, sometimes the filter doesn't show up, so we + // refresh until it shows up + await retry.try( + async () => { + const hasFilter = await filterBar.hasFilter('animal', 'dog'); + if (!hasFilter) throw new Error('filter not found'); + }, + async () => { + await browser.refresh(); + await header.waitUntilLoadingHasFinished(); + await clearSessionIds(); + } + ); await filterBar.removeFilter('animal'); const sessionIds = await getSessionIds(); expect(sessionIds.length).to.be(1);