From 85c3a96a134671cf9fc260ba6be363e44f2cf467 Mon Sep 17 00:00:00 2001 From: Tim Sullivan Date: Fri, 4 Jun 2021 15:32:55 -0700 Subject: [PATCH] [Reporting] Add `location.url` info to console message logs (#101427) --- .../server/browsers/chromium/driver_factory/index.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts b/x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts index d8a4e1ce56bfa6..1141437eae0eff 100644 --- a/x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts +++ b/x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts @@ -195,10 +195,14 @@ export class HeadlessChromiumDriverFactory { getBrowserLogger(page: puppeteer.Page, logger: LevelLogger): Rx.Observable { const consoleMessages$ = Rx.fromEvent(page, 'console').pipe( map((line) => { + const formatLine = () => `{ text: "${line.text()?.trim()}", url: ${line.location()?.url} }`; + if (line.type() === 'error') { - logger.error(line.text(), ['headless-browser-console']); + logger.error(`Error in browser console: ${formatLine()}`, ['headless-browser-console']); } else { - logger.debug(line.text(), [`headless-browser-console:${line.type()}`]); + logger.debug(`Message in browser console: ${formatLine()}`, [ + `headless-browser-console:${line.type()}`, + ]); } }) );