From 8088f1346b92d7384919d8cf3e4eb0d179746f29 Mon Sep 17 00:00:00 2001
From: Nathan L Smith <smith@nlsmith.com>
Date: Fri, 29 Jan 2021 16:27:19 -0600
Subject: [PATCH] Remove unused ui filters endpoints

---
 .../apm/server/routes/create_apm_api.ts       |  16 +-
 .../plugins/apm/server/routes/ui_filters.ts   | 154 +-----------------
 2 files changed, 10 insertions(+), 160 deletions(-)

diff --git a/x-pack/plugins/apm/server/routes/create_apm_api.ts b/x-pack/plugins/apm/server/routes/create_apm_api.ts
index aeaa6f90a7426d..7121a5973089ce 100644
--- a/x-pack/plugins/apm/server/routes/create_apm_api.ts
+++ b/x-pack/plugins/apm/server/routes/create_apm_api.ts
@@ -64,15 +64,8 @@ import {
   transactionThroughputChatsRoute,
 } from './transactions';
 import {
-  errorGroupsLocalFiltersRoute,
-  metricsLocalFiltersRoute,
-  servicesLocalFiltersRoute,
-  tracesLocalFiltersRoute,
-  transactionGroupsLocalFiltersRoute,
-  transactionsLocalFiltersRoute,
-  serviceNodesLocalFiltersRoute,
-  uiFiltersEnvironmentsRoute,
   rumOverviewLocalFiltersRoute,
+  uiFiltersEnvironmentsRoute,
 } from './ui_filters';
 import { serviceMapRoute, serviceMapServiceNodeRoute } from './service_map';
 import {
@@ -174,13 +167,6 @@ const createApmApi = () => {
     .add(transactionThroughputChatsRoute)
 
     // UI filters
-    .add(errorGroupsLocalFiltersRoute)
-    .add(metricsLocalFiltersRoute)
-    .add(servicesLocalFiltersRoute)
-    .add(tracesLocalFiltersRoute)
-    .add(transactionGroupsLocalFiltersRoute)
-    .add(transactionsLocalFiltersRoute)
-    .add(serviceNodesLocalFiltersRoute)
     .add(uiFiltersEnvironmentsRoute)
 
     // Service map
diff --git a/x-pack/plugins/apm/server/routes/ui_filters.ts b/x-pack/plugins/apm/server/routes/ui_filters.ts
index dae2962a76d105..b31c3ba260c834 100644
--- a/x-pack/plugins/apm/server/routes/ui_filters.ts
+++ b/x-pack/plugins/apm/server/routes/ui_filters.ts
@@ -6,29 +6,23 @@
 
 import * as t from 'io-ts';
 import { omit } from 'lodash';
+import { jsonRt } from '../../common/runtime_types/json_rt';
+import { LocalUIFilterName } from '../../common/ui_filter';
+import { getSearchAggregatedTransactions } from '../lib/helpers/aggregated_transactions';
+import { getEsFilter } from '../lib/helpers/convert_ui_filters/get_es_filter';
 import {
-  setupRequest,
   Setup,
+  setupRequest,
   SetupTimeRange,
 } from '../lib/helpers/setup_request';
 import { getEnvironments } from '../lib/ui_filters/get_environments';
-import { Projection } from '../projections/typings';
-import { localUIFilterNames } from '../lib/ui_filters/local_ui_filters/config';
-import { getEsFilter } from '../lib/helpers/convert_ui_filters/get_es_filter';
 import { getLocalUIFilters } from '../lib/ui_filters/local_ui_filters';
-import { getServicesProjection } from '../projections/services';
-import { getTransactionGroupsProjection } from '../projections/transaction_groups';
-import { getMetricsProjection } from '../projections/metrics';
-import { getErrorGroupsProjection } from '../projections/errors';
-import { getTransactionsProjection } from '../projections/transactions';
-import { createRoute } from './create_route';
-import { uiFiltersRt, rangeRt } from './default_api_types';
-import { jsonRt } from '../../common/runtime_types/json_rt';
-import { getServiceNodesProjection } from '../projections/service_nodes';
+import { localUIFilterNames } from '../lib/ui_filters/local_ui_filters/config';
 import { getRumPageLoadTransactionsProjection } from '../projections/rum_page_load_transactions';
-import { getSearchAggregatedTransactions } from '../lib/helpers/aggregated_transactions';
+import { Projection } from '../projections/typings';
+import { createRoute } from './create_route';
+import { rangeRt, uiFiltersRt } from './default_api_types';
 import { APMRequestHandlerContext } from './typings';
-import { LocalUIFilterName } from '../../common/ui_filter';
 
 export const uiFiltersEnvironmentsRoute = createRoute({
   endpoint: 'GET /api/apm/ui_filters/environments',
@@ -121,136 +115,6 @@ function createLocalFiltersRoute<
   });
 }
 
-export const servicesLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: `GET /api/apm/ui_filters/local_filters/services`,
-  getProjection: async ({ context, setup }) => {
-    const searchAggregatedTransactions = await getSearchAggregatedTransactions(
-      setup
-    );
-
-    return getServicesProjection({ setup, searchAggregatedTransactions });
-  },
-  queryRt: t.type({}),
-});
-
-export const transactionGroupsLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/transactionGroups',
-  getProjection: async ({ context, setup, query }) => {
-    const { transactionType, serviceName, transactionName } = query;
-
-    const searchAggregatedTransactions = await getSearchAggregatedTransactions(
-      setup
-    );
-
-    return getTransactionGroupsProjection({
-      setup,
-      options: {
-        type: 'top_transactions',
-        transactionType,
-        serviceName,
-        transactionName,
-        searchAggregatedTransactions,
-      },
-    });
-  },
-  queryRt: t.intersection([
-    t.type({
-      serviceName: t.string,
-      transactionType: t.string,
-    }),
-    t.partial({
-      transactionName: t.string,
-    }),
-  ]),
-});
-
-export const tracesLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/traces',
-  getProjection: async ({ setup, context }) => {
-    const searchAggregatedTransactions = await getSearchAggregatedTransactions(
-      setup
-    );
-
-    return getTransactionGroupsProjection({
-      setup,
-      options: { type: 'top_traces', searchAggregatedTransactions },
-    });
-  },
-  queryRt: t.type({}),
-});
-
-export const transactionsLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/transactions',
-  getProjection: async ({ context, setup, query }) => {
-    const { transactionType, serviceName, transactionName } = query;
-
-    const searchAggregatedTransactions = await getSearchAggregatedTransactions(
-      setup
-    );
-
-    return getTransactionsProjection({
-      setup,
-      transactionType,
-      serviceName,
-      transactionName,
-      searchAggregatedTransactions,
-    });
-  },
-  queryRt: t.type({
-    transactionType: t.string,
-    transactionName: t.string,
-    serviceName: t.string,
-  }),
-});
-
-export const metricsLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/metrics',
-  getProjection: ({ setup, query }) => {
-    const { serviceName, serviceNodeName } = query;
-    return getMetricsProjection({
-      setup,
-      serviceName,
-      serviceNodeName,
-    });
-  },
-  queryRt: t.intersection([
-    t.type({
-      serviceName: t.string,
-    }),
-    t.partial({
-      serviceNodeName: t.string,
-    }),
-  ]),
-});
-
-export const errorGroupsLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/errorGroups',
-  getProjection: ({ setup, query }) => {
-    const { serviceName } = query;
-    return getErrorGroupsProjection({
-      setup,
-      serviceName,
-    });
-  },
-  queryRt: t.type({
-    serviceName: t.string,
-  }),
-});
-
-export const serviceNodesLocalFiltersRoute = createLocalFiltersRoute({
-  endpoint: 'GET /api/apm/ui_filters/local_filters/serviceNodes',
-  getProjection: ({ setup, query }) => {
-    const { serviceName } = query;
-    return getServiceNodesProjection({
-      setup,
-      serviceName,
-    });
-  },
-  queryRt: t.type({
-    serviceName: t.string,
-  }),
-});
-
 export const rumOverviewLocalFiltersRoute = createLocalFiltersRoute({
   endpoint: 'GET /api/apm/ui_filters/local_filters/rumOverview',
   getProjection: async ({ setup }) => {