Skip to content

Commit

Permalink
[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to in…
Browse files Browse the repository at this point in the history
…clude new package PHASE 1 (#190832)

## Summary

The previous [PR ](#190105) was
way too big and made it hard to review without missing any bugs or
potential bugs, Thus we decided we are going to make series of smaller
PR to make things more manageable

We will be splitting it into 4 PR 
Phase 1: Creating empty packages for csp and csp-common 
Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates
in the CSP plugin where possible
Phase 3: Move Functions, Utils or Helpers, Hooks to Package
Phase 4: Misconfiguration Preview feature (with Cypress test and other
required test)

This is Phase 1 of the initiative

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
animehart and kibanamachine committed Aug 20, 2024
1 parent 349fdac commit 77ad05e
Show file tree
Hide file tree
Showing 11 changed files with 64 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ x-pack/plugins/cloud_integrations/cloud_full_story @elastic/kibana-core
x-pack/test/cloud_integration/plugins/saml_provider @elastic/kibana-core
x-pack/plugins/cloud_integrations/cloud_links @elastic/kibana-core
x-pack/plugins/cloud @elastic/kibana-core
x-pack/packages/kbn-cloud-security-posture @elastic/kibana-cloud-security-posture
x-pack/packages/kbn-cloud-security-posture-common @elastic/kibana-cloud-security-posture
x-pack/plugins/cloud_security_posture @elastic/kibana-cloud-security-posture
packages/shared-ux/code_editor/impl @elastic/appex-sharedux
packages/shared-ux/code_editor/mocks @elastic/appex-sharedux
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@
"@kbn/cloud-integration-saml-provider-plugin": "link:x-pack/test/cloud_integration/plugins/saml_provider",
"@kbn/cloud-links-plugin": "link:x-pack/plugins/cloud_integrations/cloud_links",
"@kbn/cloud-plugin": "link:x-pack/plugins/cloud",
"@kbn/cloud-security-posture": "link:x-pack/packages/kbn-cloud-security-posture",
"@kbn/cloud-security-posture-common": "link:x-pack/packages/kbn-cloud-security-posture-common",
"@kbn/cloud-security-posture-plugin": "link:x-pack/plugins/cloud_security_posture",
"@kbn/code-editor": "link:packages/shared-ux/code_editor/impl",
"@kbn/code-editor-mock": "link:packages/shared-ux/code_editor/mocks",
Expand Down
4 changes: 4 additions & 0 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@
"@kbn/cloud-links-plugin/*": ["x-pack/plugins/cloud_integrations/cloud_links/*"],
"@kbn/cloud-plugin": ["x-pack/plugins/cloud"],
"@kbn/cloud-plugin/*": ["x-pack/plugins/cloud/*"],
"@kbn/cloud-security-posture": ["x-pack/packages/kbn-cloud-security-posture"],
"@kbn/cloud-security-posture/*": ["x-pack/packages/kbn-cloud-security-posture/*"],
"@kbn/cloud-security-posture-common": ["x-pack/packages/kbn-cloud-security-posture-common"],
"@kbn/cloud-security-posture-common/*": ["x-pack/packages/kbn-cloud-security-posture-common/*"],
"@kbn/cloud-security-posture-plugin": ["x-pack/plugins/cloud_security_posture"],
"@kbn/cloud-security-posture-plugin/*": ["x-pack/plugins/cloud_security_posture/*"],
"@kbn/code-editor": ["packages/shared-ux/code_editor/impl"],
Expand Down
6 changes: 5 additions & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@
"xpack.cloudDefend": "plugins/cloud_defend",
"xpack.cloudLinks": "plugins/cloud_integrations/cloud_links",
"xpack.cloudDataMigration": "plugins/cloud_integrations/cloud_data_migration",
"xpack.csp": "plugins/cloud_security_posture",
"xpack.csp": [
"plugins/cloud_security_posture",
"packages/kbn-cloud-security-posture-common",
"packages/kbn-cloud-security-posture"
],
"xpack.customBranding": "plugins/custom_branding",
"xpack.dashboard": "plugins/dashboard_enhanced",
"xpack.dataQuality": "plugins/data_quality",
Expand Down
9 changes: 9 additions & 0 deletions x-pack/packages/kbn-cloud-security-posture-common/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# @kbn/cloud-security-posture-common

This package provides common code consumed in both the browser, i.e. the
`packages/kbn-cloud-security-posture` package and `plugins/cloud_security_posture` plugin, and on the server, i.e. the
`plugins/cloud_security_posture` plugin.

## Maintainers

Maintained by the Cloud Security Team
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

{
"id": "@kbn/cloud-security-posture-common",
"owner": "@elastic/kibana-cloud-security-posture",
"type": "shared-common"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "@kbn/cloud-security-posture-common",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0",
"description": "Shared components for cloud security posture, both client and server side"
}
9 changes: 9 additions & 0 deletions x-pack/packages/kbn-cloud-security-posture/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# @kbn/cloud-security-posture

This package includes
- Hooks that's used on Flyout component that's used in Alerts page on Security Solution Plugins as well as components on CSP plugin
- Utilities and types thats used for the Hooks above as well as in CSP plugins

## Maintainers

Maintained by the Cloud Security Team
5 changes: 5 additions & 0 deletions x-pack/packages/kbn-cloud-security-posture/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"id": "@kbn/cloud-security-posture",
"owner": "@elastic/kibana-cloud-security-posture",
"type": "shared-browser"
}
7 changes: 7 additions & 0 deletions x-pack/packages/kbn-cloud-security-posture/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "@kbn/cloud-security-posture",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0",
"description": "Shared components for cloud security posture, client side"
}
8 changes: 8 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3628,10 +3628,18 @@
version "0.0.0"
uid ""

"@kbn/cloud-security-posture-common@link:x-pack/packages/kbn-cloud-security-posture-common":
version "0.0.0"
uid ""

"@kbn/cloud-security-posture-plugin@link:x-pack/plugins/cloud_security_posture":
version "0.0.0"
uid ""

"@kbn/cloud-security-posture@link:x-pack/packages/kbn-cloud-security-posture":
version "0.0.0"
uid ""

"@kbn/cloud@link:packages/cloud":
version "0.0.0"
uid ""
Expand Down

0 comments on commit 77ad05e

Please sign in to comment.