From 6c305e51cc64c24f5fdf32fcac9b80def10364df Mon Sep 17 00:00:00 2001
From: Constance Chen <constance.chen.3@gmail.com>
Date: Thu, 17 Jun 2021 17:33:20 -0700
Subject: [PATCH] Update Account Settings with personal layout + write tests

+ add related KibanaLogic branch coverage
---
 .../shared/kibana/kibana_logic.test.ts        |  6 ++
 .../account_settings.test.tsx                 | 57 +++++++++++++++++++
 .../account_settings/account_settings.tsx     |  6 +-
 3 files changed, 67 insertions(+), 2 deletions(-)
 create mode 100644 x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx

diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/kibana/kibana_logic.test.ts b/x-pack/plugins/enterprise_search/public/applications/shared/kibana/kibana_logic.test.ts
index 4cc907c3de9e4c..39392d0c5c78e6 100644
--- a/x-pack/plugins/enterprise_search/public/applications/shared/kibana/kibana_logic.test.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/shared/kibana/kibana_logic.test.ts
@@ -33,6 +33,12 @@ describe('KibanaLogic', () => {
       expect(KibanaLogic.values.config).toEqual({});
     });
 
+    it('gracefully handles disabled security', () => {
+      mountKibanaLogic({ ...mockKibanaValues, security: undefined } as any);
+
+      expect(KibanaLogic.values.security).toEqual({});
+    });
+
     it('gracefully handles non-cloud installs', () => {
       mountKibanaLogic({ ...mockKibanaValues, cloud: undefined } as any);
 
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx
new file mode 100644
index 00000000000000..5ff80a7683db6a
--- /dev/null
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx
@@ -0,0 +1,57 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import '../../../__mocks__/shallow_useeffect.mock';
+import { mockKibanaValues } from '../../../__mocks__/kea_logic';
+
+import React from 'react';
+
+import { shallow } from 'enzyme';
+
+import { AccountSettings } from './';
+
+describe('AccountSettings', () => {
+  const {
+    security: {
+      authc: { getCurrentUser },
+      uiApi: {
+        components: { getPersonalInfo, getChangePassword },
+      },
+    },
+  } = mockKibanaValues;
+
+  const mockCurrentUser = (user?: unknown) =>
+    (getCurrentUser as jest.Mock).mockReturnValue(Promise.resolve(user));
+
+  beforeAll(() => {
+    mockCurrentUser();
+  });
+
+  it('gets the current user on mount', () => {
+    shallow(<AccountSettings />);
+
+    expect(getCurrentUser).toHaveBeenCalled();
+  });
+
+  it('does not render if the current user does not exist', async () => {
+    mockCurrentUser(null);
+    const wrapper = await shallow(<AccountSettings />);
+
+    expect(wrapper.isEmptyRender()).toBe(true);
+  });
+
+  it('renders the security UI components when the user exists', async () => {
+    mockCurrentUser({ username: 'mock user' });
+    (getPersonalInfo as jest.Mock).mockReturnValue(<div data-test-subj="PersonalInfo" />);
+    (getChangePassword as jest.Mock).mockReturnValue(<div data-test-subj="ChangePassword" />);
+
+    const wrapper = await shallow(<AccountSettings />);
+
+    expect(wrapper.childAt(0).dive().find('[data-test-subj="PersonalInfo"]')).toHaveLength(1);
+    expect(wrapper.childAt(1).dive().find('[data-test-subj="ChangePassword"]')).toHaveLength(1);
+  });
+});
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.tsx
index e28faaeec8993a..313d3ffa59d48f 100644
--- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.tsx
@@ -11,6 +11,8 @@ import { useValues } from 'kea';
 
 import type { AuthenticatedUser } from '../../../../../../security/public';
 import { KibanaLogic } from '../../../shared/kibana/kibana_logic';
+import { PersonalDashboardLayout } from '../../components/layout';
+import { ACCOUNT_SETTINGS_TITLE } from '../../constants';
 
 export const AccountSettings: React.FC = () => {
   const { security } = useValues(KibanaLogic);
@@ -31,9 +33,9 @@ export const AccountSettings: React.FC = () => {
   }
 
   return (
-    <>
+    <PersonalDashboardLayout pageChrome={[ACCOUNT_SETTINGS_TITLE]}>
       <PersonalInfo user={currentUser} />
       <ChangePassword user={currentUser} />
-    </>
+    </PersonalDashboardLayout>
   );
 };