From 679dc805e837ef96bad6d20b72b2e1858a3b7770 Mon Sep 17 00:00:00 2001
From: Alexi Doak <109488926+doakalexi@users.noreply.github.com>
Date: Mon, 12 Jun 2023 14:46:31 -0400
Subject: [PATCH] [ResponseOps][rule registry] Remove usages of `refresh: true`
 (#159252)

Resolves https://github.com/elastic/kibana/issues/158139

## Summary

Removes refresh: true from the rule registry


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---
 .../rule_registry/server/alert_data_client/alerts_client.ts     | 2 --
 .../alert_data_client/tests/remove_cases_from_alerts.test.ts    | 1 -
 .../server/utils/create_persistence_rule_type_wrapper.ts        | 2 +-
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts b/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
index 9e66facd9d160c..f5d085392814b2 100644
--- a/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
+++ b/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
@@ -789,7 +789,6 @@ export class AlertsClient {
         const result = await this.esClient.updateByQuery({
           index,
           conflicts: 'proceed',
-          refresh: true,
           body: {
             script: {
               source: `if (ctx._source['${ALERT_WORKFLOW_STATUS}'] != null) {
@@ -929,7 +928,6 @@ export class AlertsClient {
       await this.esClient.updateByQuery({
         index,
         conflicts: 'proceed',
-        refresh: true,
         body: {
           script: {
             source: painlessScript,
diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts b/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts
index 8b6f075edfab4b..f96b34d1154c22 100644
--- a/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts
+++ b/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts
@@ -164,7 +164,6 @@ describe('remove cases from alerts', () => {
           "conflicts": "proceed",
           "ignore_unavailable": true,
           "index": "undefined-*",
-          "refresh": true,
         }
       `);
     });
diff --git a/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts b/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
index 04ba481e7a533a..c2e43c9fe23b37 100644
--- a/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
+++ b/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
@@ -355,7 +355,7 @@ export const createPersistenceRuleTypeWrapper: CreatePersistenceRuleTypeWrapper
 
                 const bulkResponse = await ruleDataClientWriter.bulk({
                   body: [...duplicateAlertUpdates, ...mapAlertsToBulkCreate(augmentedAlerts)],
-                  refresh: true,
+                  refresh: 'wait_for',
                 });
 
                 if (bulkResponse == null) {