From 59196b6cc47da2bf7ce0300ef8a6cb994f4c3f16 Mon Sep 17 00:00:00 2001 From: Nathan L Smith Date: Wed, 16 Jun 2021 00:12:46 -0500 Subject: [PATCH] Only call addClickHandlers once --- .../public/hooks/use_breadcrumbs.ts | 26 ++++++++----------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts b/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts index 14c1dff988e733..241a978d36948b 100644 --- a/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts +++ b/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts @@ -45,26 +45,22 @@ export const useBreadcrumbs = (extraCrumbs: ChromeBreadcrumb[]) => { } = useKibana(); const setTitle = docTitle.change; const appPath = getUrlForApp('observability-overview') ?? ''; - const navigate = navigateToUrl; useEffect(() => { - const breadcrumbs = addClickHandlers( - [ - { - text: i18n.translate('xpack.observability.breadcrumbs.observabilityLinkText', { - defaultMessage: 'Observability', - }), - href: appPath + '/overview', - }, - ...extraCrumbs, - ], - navigate - ); + const breadcrumbs = [ + { + text: i18n.translate('xpack.observability.breadcrumbs.observabilityLinkText', { + defaultMessage: 'Observability', + }), + href: appPath + '/overview', + }, + ...extraCrumbs, + ]; if (setBreadcrumbs) { - setBreadcrumbs(addClickHandlers(breadcrumbs, navigate)); + setBreadcrumbs(addClickHandlers(breadcrumbs, navigateToUrl)); } if (setTitle) { setTitle(getTitleFromBreadCrumbs(breadcrumbs)); } - }, [appPath, extraCrumbs, navigate, params, setBreadcrumbs, setTitle]); + }, [appPath, extraCrumbs, navigateToUrl, params, setBreadcrumbs, setTitle]); };