From 087df41fdfb9772a6c7a49abb40fd1c7dd80bedc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Fern=C3=A1ndez?= Date: Fri, 24 Jan 2020 14:56:21 +0100 Subject: [PATCH 001/109] Fix the scale of the search markers (#55731) (#55814) The search markers where placed on the minimap using a different scale than the density chart and time ruler. That made the log stream jump to unexpected time positions when the user clicked on a search marker. This also fixes an problem where the search markers didn't move alongside the rest of the minimap when the user dragged and dropped it. Co-authored-by: Elastic Machine --- .../logging/log_minimap/log_minimap.tsx | 19 +++++++++---------- .../logging/log_minimap/search_markers.tsx | 2 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/x-pack/legacy/plugins/infra/public/components/logging/log_minimap/log_minimap.tsx b/x-pack/legacy/plugins/infra/public/components/logging/log_minimap/log_minimap.tsx index ad47d17fe3db9c..75d8c5a47d32dd 100644 --- a/x-pack/legacy/plugins/infra/public/components/logging/log_minimap/log_minimap.tsx +++ b/x-pack/legacy/plugins/infra/public/components/logging/log_minimap/log_minimap.tsx @@ -215,6 +215,15 @@ export class LogMinimap extends React.Component + + {highlightedInterval ? ( ) : null} - - - { .range([0, height]); return ( - + {buckets.map(bucket => ( Date: Fri, 24 Jan 2020 15:36:02 +0100 Subject: [PATCH 002/109] [Console] Remove z-index from editor panes and move it to the resizer (#55813) (#55826) * Remove z-index from editor panes and move it to the resizer * Update comment --- .../console/public/np_ready/application/styles/_app.scss | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/legacy/core_plugins/console/public/np_ready/application/styles/_app.scss b/src/legacy/core_plugins/console/public/np_ready/application/styles/_app.scss index b89a43f7455a54..3b6297f9cdbff7 100644 --- a/src/legacy/core_plugins/console/public/np_ready/application/styles/_app.scss +++ b/src/legacy/core_plugins/console/public/np_ready/application/styles/_app.scss @@ -27,9 +27,6 @@ // Required on IE11 to render ace editor correctly after first input. position: relative; - // Give the aria selection border priority when the divider is selected - z-index: 0; - &__spinner { width: 100%; } @@ -38,8 +35,6 @@ .conApp__output { display: flex; flex: 1 1 1px; - // Give the aria selection border priority when the divider is selected - z-index: -1; } .conApp__textAreaLabelHack, @@ -76,6 +71,8 @@ .conApp__resizer { @include kbnResizer; + // Give the aria selection border priority when the divider is selected on IE11 and Chrome + z-index: $euiZLevel1; } // SASSTODO: This component seems to not be used anymore? From 6b2d5b10a2c3e1eda94b30ca02cf6c17705a825c Mon Sep 17 00:00:00 2001 From: Jean-Louis Leysens Date: Fri, 24 Jan 2020 15:37:16 +0100 Subject: [PATCH 003/109] Move SplitPanel to kibana_react (#55529) (#55828) * split_panel component -> kibana_react * Update useEffect for console warning * `console` -> `kibana-react` i18n namespace * Update when warning about children is emitted in split panel component Co-authored-by: Elastic Machine Co-authored-by: Elastic Machine --- .../np_ready/application/components/index.ts | 1 - .../application/containers/editor/editor.tsx | 2 +- .../vis/editors/default/default_editor.tsx | 5 +---- src/plugins/kibana_react/public/index.ts | 1 + .../__snapshots__/split_panel.test.tsx.snap | 0 .../public}/split_panel/components/resizer.tsx | 2 +- .../public}/split_panel/containers/panel.tsx | 0 .../split_panel/containers/panel_container.tsx | 17 +++++++++++++++-- .../public}/split_panel/context.tsx | 0 .../kibana_react/public}/split_panel/index.ts | 0 .../public}/split_panel/registry.ts | 4 ---- .../public}/split_panel/split_panel.test.tsx | 0 12 files changed, 19 insertions(+), 13 deletions(-) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/__snapshots__/split_panel.test.tsx.snap (100%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/components/resizer.tsx (94%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/containers/panel.tsx (100%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/containers/panel_container.tsx (89%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/context.tsx (100%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/index.ts (100%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/registry.ts (92%) rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/split_panel.test.tsx (100%) diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts b/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts index 4669e210e7c2d8..eccde899a2640c 100644 --- a/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts +++ b/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts @@ -17,7 +17,6 @@ * under the License. */ -export * from './split_panel'; export { SomethingWentWrongCallout } from './something_went_wrong_callout'; export { TopNavMenuItem, TopNavMenu } from './top_nav_menu'; export { ConsoleMenu } from './console_menu'; diff --git a/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx b/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx index 7be1382760eb91..b42d791e5acd8e 100644 --- a/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx +++ b/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx @@ -21,7 +21,7 @@ import React, { useCallback } from 'react'; import { debounce } from 'lodash'; import { EditorContentSpinner } from '../../components'; -import { Panel, PanelsContainer } from '../../components/split_panel'; +import { Panel, PanelsContainer } from '../../../../../../../../plugins/kibana_react/public'; import { Editor as EditorUI, EditorOutput } from './legacy/console_editor'; import { StorageKeys } from '../../../services'; import { useEditorReadContext, useServicesContext } from '../../contexts'; diff --git a/src/legacy/ui/public/vis/editors/default/default_editor.tsx b/src/legacy/ui/public/vis/editors/default/default_editor.tsx index 3e99bb83d224f6..efe5a79cd027e0 100644 --- a/src/legacy/ui/public/vis/editors/default/default_editor.tsx +++ b/src/legacy/ui/public/vis/editors/default/default_editor.tsx @@ -23,10 +23,7 @@ import { start as embeddables } from '../../../../../core_plugins/embeddable_api import { EditorRenderProps } from '../../../../../core_plugins/kibana/public/visualize/np_ready/types'; import { VisualizeEmbeddable } from '../../../../../core_plugins/visualizations/public/embeddable'; import { VisualizeEmbeddableFactory } from '../../../../../core_plugins/visualizations/public/embeddable/visualize_embeddable_factory'; -import { - PanelsContainer, - Panel, -} from '../../../../../core_plugins/console/public/np_ready/application/components/split_panel'; +import { PanelsContainer, Panel } from '../../../../../../plugins/kibana_react/public'; import './vis_type_agg_filter'; import { DefaultEditorSideBar } from './components/sidebar'; diff --git a/src/plugins/kibana_react/public/index.ts b/src/plugins/kibana_react/public/index.ts index cfe89f16e99dd5..81f2e694e8e5b5 100644 --- a/src/plugins/kibana_react/public/index.ts +++ b/src/plugins/kibana_react/public/index.ts @@ -25,5 +25,6 @@ export * from './overlays'; export * from './ui_settings'; export * from './field_icon'; export * from './table_list_view'; +export * from './split_panel'; export { useUrlTracker } from './use_url_tracker'; export { toMountPoint } from './util'; diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap b/src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap similarity index 100% rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap rename to src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx b/src/plugins/kibana_react/public/split_panel/components/resizer.tsx similarity index 94% rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx rename to src/plugins/kibana_react/public/split_panel/components/resizer.tsx index 67fe92b7eb03a2..306db4c7d9a638 100644 --- a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx +++ b/src/plugins/kibana_react/public/split_panel/components/resizer.tsx @@ -35,7 +35,7 @@ export function Resizer(props: Props) {